Skip to content

Update variable names in ZK aff-g and fix minor typos #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jfdreis wants to merge 2 commits into
base: cggmp24/m
Choose a base branch
from
Open

Update variable names in ZK aff-g and fix minor typos #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02a6067
Update variable names in ZK aff-g and fix minor typos
jfdreis Oct 10, 2025
2d4dbd0
update e_at_d, e_at_y to challenge_at_d,challenge_at_y
jfdreis Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cggmp24/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@
)]
#![forbid(clippy::disallowed_methods, missing_docs, unsafe_code)]
#![cfg_attr(not(test), forbid(unused_crate_dependencies))]
#![cfg_attr(docsrs, feature(doc_auto_cfg))]
#![cfg_attr(docsrs, feature(doc_cfg))]

#[cfg(feature = "hd-wallet")]
pub use hd_wallet;
Expand Down
24 changes: 12 additions & 12 deletions cggmp24/src/signing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1039,8 +1039,8 @@ where
},
&R_j.into(),
pi_aff::Data {
key_j: enc_j,
key_i: &dec_i,
n_j: enc_j,
n_i: &dec_i,
c: &ciphertext_j.K,
d: &D_ji,
y: &F_ji,
Expand All @@ -1049,8 +1049,8 @@ where
pi_aff::PrivateData {
x: &utils::scalar_to_pm_bignumber(&gamma_i),
y: &(-&beta_ij).complete(),
nonce: &s_ij,
nonce_y: &r_ij,
rho: &s_ij,
rho_y: &r_ij,
},
&security_params.pi_aff,
&mut *rng,
Expand All @@ -1067,8 +1067,8 @@ where
},
&R_j.into(),
pi_aff::Data {
key_j: enc_j,
key_i: &dec_i,
n_j: enc_j,
n_i: &dec_i,
c: &ciphertext_j.K,
d: &hat_D_ji,
y: &hat_F_ji,
Expand All @@ -1077,8 +1077,8 @@ where
pi_aff::PrivateData {
x: &utils::scalar_to_pm_bignumber(x_i),
y: &(-&hat_beta_ij).complete(),
nonce: &hat_s_ij,
nonce_y: &hat_r_ij,
rho: &hat_s_ij,
rho_y: &hat_r_ij,
},
&security_params.pi_aff,
&mut *rng,
Expand Down Expand Up @@ -1153,8 +1153,8 @@ where
},
&R_i.into(),
pi_aff::Data {
key_j: &dec_i,
key_i: enc_j,
n_j: &dec_i,
n_i: enc_j,
c: &K_i,
d: &msg.D,
y: &msg.F,
Expand All @@ -1174,8 +1174,8 @@ where
},
&R_i.into(),
pi_aff::Data {
key_j: &dec_i,
key_i: enc_j,
n_j: &dec_i,
n_i: enc_j,
c: &K_i,
d: &msg.hat_D,
y: &msg.hat_F,
Expand Down
4 changes: 2 additions & 2 deletions cggmp24/src/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ impl SecurityParams {
pub fn new<L: SecurityLevel>() -> Self {
Self {
pi_aff: pi_aff::SecurityParams {
l_x: L::ELL,
l_y: L::ELL_PRIME,
l: L::ELL,
l_prime: L::ELL_PRIME,
epsilon: L::EPSILON,
},
pi_enc_elg: pi_enc_elg::SecurityParams {
Expand Down
2 changes: 1 addition & 1 deletion key-share/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#![allow(non_snake_case)]
#![deny(missing_docs, clippy::unwrap_used, clippy::expect_used, clippy::panic)]
#![forbid(unused_crate_dependencies)]
#![cfg_attr(docsrs, feature(doc_auto_cfg))]
#![cfg_attr(docsrs, feature(doc_cfg))]
#![no_std]

#[cfg(feature = "std")]
Expand Down
4 changes: 2 additions & 2 deletions paillier-zk/src/curve.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,9 @@ impl generic_ec::core::IntegerEncoding for Scalar {
}

#[derive(Debug, PartialEq, Eq, Clone, Copy, Hash, PartialOrd, Ord, Default)]
pub struct C;
pub struct E;

impl generic_ec::Curve for C {
impl generic_ec::Curve for E {
const CURVE_NAME: &'static str = "test curve Z/1000000007";
type Point = MillionRing;
type Scalar = Scalar;
Expand Down
6 changes: 3 additions & 3 deletions paillier-zk/src/dlog_with_el_gamal_commitment.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ mod test {

#[test]
fn passing_million() {
passing_test::<crate::curve::C, sha2::Sha256>()
passing_test::<crate::curve::E, sha2::Sha256>()
}
#[test]
fn failing_check_1_p256() {
Expand All @@ -386,7 +386,7 @@ mod test {

#[test]
fn failing_check_1_million() {
failing_check_lambda_::<crate::curve::C, sha2::Sha256>()
failing_check_lambda_::<crate::curve::E, sha2::Sha256>()
}
#[test]
fn failing_check_2_p256() {
Expand All @@ -395,6 +395,6 @@ mod test {

#[test]
fn failing_check_2_million() {
failing_check_y_::<crate::curve::C, sha2::Sha256>()
failing_check_y_::<crate::curve::E, sha2::Sha256>()
}
}
Loading
Loading