Skip to content

Conversation

@haobibo
Copy link
Member

@haobibo haobibo commented Nov 8, 2025

No description provided.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 108 to 116
pip install -Uq --pre jupyterhub jupyter_client \
dockerspawner jupyterhub-kubespawner jupyterhub-systemdspawner wrapspawner \
jupyterhub-ldapauthenticator jupyterhub-kerberosauthenticator \
jupyterhub-firstuseauthenticator jupyterhub-hmacauthenticator jupyterhub-ltiauthenticator \
jupyterhub-nativeauthenticator jupyterhub-tmpauthenticator \
oauthenticator[googlegroups,mediawiki] jupyterhub-idle-culler \
psycopg pymysql sqlalchemy-cockroachdb \
psutil pycurl py-spy \
jupyterhub-traefik-proxy configurable-http-proxy

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid enabling prerelease versions for all hub dependencies

The new pip install line passes --pre before a long list of authenticator/spawner packages. Previously only jupyterhub was installed with --pre, leaving the rest on their latest stable releases. With this change any prerelease build of packages like oauthenticator or jupyterhub-kubespawner will now be selected automatically, even when those builds target unreleased JupyterHub APIs. That increases the risk of build failures (no prerelease wheels published) or runtime incompatibilities. If the intention is only to allow prereleases of JupyterHub itself, move --pre so it applies solely to jupyterhub and keep other dependencies on stable versions.

Useful? React with 👍 / 👎.

@haobibo haobibo merged commit f196e0f into main Nov 9, 2025
12 checks passed
@haobibo haobibo deleted the dev/update-hub branch November 9, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants