Security review 1.20.0 #913
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganize src tree
Do not check dynamic network in SWAP mode
Bump plugin SDK submodule
Allocate 1k memory for plugins
Removed unused derivation paths
Cleanup plugin interface
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Add skip button for eip712 raw
Fix STRUCT_TYPE value 0x0A for Safe Signers
Field-less GCS support
Fixed GCS with legacy TX
Fixed GCS TX context pop
…ed_signature Fix Python client with pre-computed signature
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* error signature * make test more explicit * fix: hash ctx stack in arrays * fix: build * chore: removed whitespace * fix: format --------- Co-authored-by: franco-gondi <[email protected]>
And some comments
Was only used by the ERC-20 "internal plugin"
Add support for displaying extra data trailing calldata in ERC20 calls
* Fix crash with mem_free * Add flag 'CHALLENGE_NO_CHECK' to bypass the challenge check * Cleanup EIP712 calldata parameters * Ensure UI alloacted tag/value buffers will be freeed * Add Batch TX handling * Support Batch transactions in EIP712 * Add GCS batch test * Add eip712 batch test * Add new snapshots
Added a new trusted name source (multisig address book)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a detailed description of what was done in this PR.
(And mentioned if linked to an issue docs)
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it.
Additional comments
Please post additional comments in this section if you have them, otherwise delete it.