Fixed hash display setting with EIP-712 on Nano devices #914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage with the hash display setting turned on
apaillier-ledger
force-pushed
the
fix/apa/eip712_double_message_hash_on_nano
branch
from
2982b6f to
8e3f81b
Compare
cedelavergne-ledger
approved these changes
Nov 28, 2025
apaillier-ledger
deleted the
fix/apa/eip712_double_message_hash_on_nano
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Would show the message hash twice when "blind-signing" a 712 message with the setting turned on.
Only on LNS+ / LNX.
Changes include