refactor(rocketchat-stats): improve output

Author: markuslf

CHANGELOG.md

@@ -59,6 +59,7 @@ Monitoring Plugins:
 * nextcloud-version: modernize code
 * php-status: always assume http://localhost/monitoring.php and, if not found, be tolerant
 * redis-status, valkey-status: modernize code and unify both plugins again after [PR #954](https://github.com/Linuxfabrik/monitoring-plugins/pull/954)
+* rocketchat-stats: improve output
 * updates: adapt to updated powershell.py library
 
 

check-plugins/rocketchat-stats/README.md

@@ -59,8 +59,8 @@ Output:
 * Users: 325 total, 8 online, 0 busy, 1 away, 316 offline
 * Types and Distribution: 9 connected, 223 activated users, 0 activated guests, 100 deactivated users, 2 Rocket.Chat app users
 * Total Uploads: 6285, 4.3GiB size
-* Total Rooms: 672 rooms, 1 channel, 96 private groups, 440 direct msg rooms, 0 discussions, 135 omnichannel rooms
-* Total Messages: 295.2K, 829 threads, 5 in channels, 178.3K in priv groups, 115.0K in direct msg, 1.9K in omnichannel
+* Total Rooms: 672 (1 channel, 96 private groups, 440 direct msg rooms, 0 discussions, 135 omnichannel rooms)
+* Total Messages: 295.2K (829 threads, 5 in channels, 178.3K in priv groups, 115.0K in direct msg, 1.9K in omnichannel)
 ```
 
 

check-plugins/rocketchat-stats/rocketchat-stats

@@ -20,7 +20,7 @@ import lib.rocket  # pylint: disable=C0413
 from lib.globals import (STATE_OK, STATE_UNKNOWN) # pylint: disable=C0413
 
 __author__ = 'Linuxfabrik GmbH, Zurich/Switzerland'
-__version__ = '2025100601'
+__version__ = '2025112601'
 
 DESCRIPTION = """This plugin allows you to track statistics about a Rocket.Chat server,
                  structured in the same way as on the https://rocket.chat/admin/info page.
@@ -171,9 +171,8 @@ def main():
         lib.human.bytes2human(result.get('uploadsTotalSize', 0)),
     )
 
-    msg += '\n* Total Rooms: {} ({}, {} {}, {} private {}, {} direct msg {}, {} {}, {} omnichannel {})'.format( # pylint: disable=C0301
+    msg += '\n* Total Rooms: {} ({} {}, {} private {}, {} direct msg {}, {} {}, {} omnichannel {})'.format( # pylint: disable=C0301
         result.get('totalRooms', 'n/a'),
-        lib.txt.pluralize('room', result.get('totalRooms', 0)),
         result.get('totalChannels', 'n/a'),
         lib.txt.pluralize('channel', result.get('totalChannels', 0)),
         result.get('totalPrivateGroups', 'n/a'),
@@ -186,7 +185,7 @@ def main():
         lib.txt.pluralize('room', result.get('totalLivechat', 0)),
     )
 
-    msg += '\n* Total Messages: {}, {} {}, {} in channels, {} in priv groups, {} in direct msg, {} in omnichannel'.format( # pylint: disable=C0301
+    msg += '\n* Total Messages: {} ({} {}, {} in channels, {} in priv groups, {} in direct msg, {} in omnichannel)'.format( # pylint: disable=C0301
         lib.human.number2human(result.get('totalMessages', 0)),
         result.get('totalThreads', 'n/a'),
         lib.txt.pluralize('thread', result.get('totalThreads', 0)),