Skip to content

Commit 9ceb01c

Browse files
committed
Debug-log compaction failures
Better than dropping them on the floor!
1 parent ddd84ee commit 9ceb01c

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/persist-client/src/internal/compact.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -240,8 +240,12 @@ where
240240
let res = Self::compact_and_apply(&machine, req)
241241
.instrument(compact_span)
242242
.await;
243-
if let Ok(maintenance) = res {
244-
maintenance.start_performing(&machine, &gc);
243+
244+
match res {
245+
Ok(maintenance) => maintenance.start_performing(&machine, &gc),
246+
Err(err) => {
247+
debug!(shard_id =? machine.shard_id(), "compaction failed: {err:#}")
248+
}
245249
}
246250

247251
// we can safely ignore errors here, it's possible the caller

0 commit comments

Comments
 (0)