test: Fix FATAL: sorry, too many clients already

amotl · amotl · commit 8b3ea4f55c3d · 2023-12-19T21:26:03.000+01:00
Dispose the SQLAlchemy engine object after use within test utility functions.
diff --git a/target_postgres/tests/test_target_postgres.py b/target_postgres/tests/test_target_postgres.py
@@ -132,6 +132,7 @@ def verify_data(
                 sqlalchemy.text(f"SELECT COUNT(*) FROM {full_table_name}")
             )
             assert result.first()[0] == number_of_rows
+    engine.dispose()
 
 
 def verify_schema(
@@ -169,6 +170,7 @@ def verify_schema(
                     f"Column '{column.name}' (with type '{column.type}') "
                     f"does not match expected type: {column_type_expected}"
                 )
+    engine.dispose()
 
 
 def test_sqlalchemy_url_config(postgres_config_no_ssl):

Original file line number	Diff line number	Diff line change
`@@ -132,6 +132,7 @@ def verify_data(`
`132`	`132`	`sqlalchemy.text(f"SELECT COUNT(*) FROM {full_table_name}")`
`133`	`133`	`)`
`134`	`134`	`assert result.first()[0] == number_of_rows`
	`135`	`+ engine.dispose()`
`135`	`136`
`136`	`137`
`137`	`138`	`def verify_schema(`
`@@ -169,6 +170,7 @@ def verify_schema(`
`169`	`170`	`f"Column '{column.name}' (with type '{column.type}') "`
`170`	`171`	`f"does not match expected type: {column_type_expected}"`
`171`	`172`	`)`
	`173`	`+ engine.dispose()`
`172`	`174`
`173`	`175`
`174`	`176`	`def test_sqlalchemy_url_config(postgres_config_no_ssl):`