Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint-build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- run: yarn --immutable
- run: yarn workspace ${{ matrix.package-name }} lint:changelog
- run: yarn workspace ${{ matrix.package-name }} changelog:validate
- name: Require clean working directory
shell: bash
run: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
needs: lint-build-test
uses: ./.github/workflows/sonar-cloud.yml
secrets:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

is-release:
name: Determine whether this is a release merge commit
Expand All @@ -44,7 +44,7 @@ jobs:
- id: is-release
uses: MetaMask/action-is-release@v1
with:
commit-starts-with: 'Release [version]'
commit-starts-with: 'Release [version],Release v[version],Release/[version],Release/v[version],Release `[version]`'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Release Detection Fails with Multiple Patterns

The is-release job's commit-starts-with input provides multiple release patterns as a single comma-separated string. The MetaMask/action-is-release action likely misinterprets this, which could prevent release commits from being detected.

Fix in Cursor Fix in Web


publish-release:
name: Publish release
Expand Down Expand Up @@ -79,4 +79,4 @@ jobs:
passed="${{ needs.all-jobs-complete.outputs.passed }}"
if [[ $passed != "true" ]]; then
exit 1
fi
fi
10 changes: 5 additions & 5 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,11 @@ packages/examples/test1/ios/test1.xcworkspace/xcshareddata/IDEWorkspaceChecks.pl
# See: https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored
**/.pnp.*
**/.yarn/*
**/!.yarn/patches
**/!.yarn/plugins
**/!.yarn/releases
**/!.yarn/sdks
**/!.yarn/versions
!**/.yarn/patches
!**/.yarn/plugins
!**/.yarn/releases
!**/.yarn/sdks
!**/.yarn/versions
packages/devnext/next.webpack.config.json
packages/devreact/webpack.config.json
.tool-versions
Expand Down
52 changes: 52 additions & 0 deletions .yarn/plugins/@yarnpkg/plugin-constraints.cjs

Large diffs are not rendered by default.

6 changes: 4 additions & 2 deletions .yarnrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,16 @@ logFilters:
- code: YN0004
level: discard

nodeLinker: node-modules

nmHoistingLimits: workspaces

nodeLinker: node-modules

plugins:
- path: .yarn/plugins/@yarnpkg/plugin-allow-scripts.cjs
spec: "https://raw.githubusercontent.com/LavaMoat/LavaMoat/main/packages/yarn-plugin-allow-scripts/bundles/@yarnpkg/plugin-allow-scripts.js"
- path: .yarn/plugins/@yarnpkg/plugin-workspace-tools.cjs
spec: "@yarnpkg/plugin-workspace-tools"
- path: .yarn/plugins/@yarnpkg/plugin-constraints.cjs
spec: "@yarnpkg/plugin-constraints"

yarnPath: .yarn/releases/yarn-3.5.1.cjs
4 changes: 4 additions & 0 deletions commitlint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,8 @@ module.exports = {
rules: {
'body-max-line-length': [0, 'always', 100],
},
ignores: [
// Commits starting with "Release X.Y.Z" are ignored
(commit) => /^(Initialize|Update) Release \d+\.\d+\.\d+/u.test(commit),
],
};
4 changes: 2 additions & 2 deletions docs/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ This repository relies on Yarn's [workspaces feature](https://yarnpkg.com/featur
> **Note**
>
> - `workspaceName` in the Yarn documentation is the `name` field within a package's `package.json`, e.g., `@metamask/sdk`, not the directory where it is located, e.g., `packages/sdk`.
> - `commandName` in the Yarn documentation is any sub-command that the `yarn` executable would usually take. Pay special attention to the difference between `run` vs `exec`. If you want to run a package script, you would use `run`, e.g., `yarn workspace @metamask/sdk run lint:changelog`; but if you want to run _any_ shell command, you'd use `exec`, e.g. `yarn workspace @metamask/sdk exec cat package.json | jq '.version'`.
> - `commandName` in the Yarn documentation is any sub-command that the `yarn` executable would usually take. Pay special attention to the difference between `run` vs `exec`. If you want to run a package script, you would use `run`, e.g., `yarn workspace @metamask/sdk run changelog:validate`; but if you want to run _any_ shell command, you'd use `exec`, e.g. `yarn workspace @metamask/sdk exec cat package.json | jq '.version'`.

## Releasing

Expand All @@ -163,7 +163,7 @@ The [`create-release-branch`](https://github.com/MetaMask/create-release-branch)
- Reword changelog entries to explain changes in terms that users of the package will understand (e.g., avoid referencing internal variables/concepts).
- Consolidate related changes into one change entry if it makes it easier to comprehend.

Run `yarn lint:changelog` to check that all changelogs are correctly formatted.
Run `yarn changelog:validate` to check that all changelogs are correctly formatted.

Commit and push the branch.

Expand Down
8 changes: 5 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,15 @@
"light-build": "yarn install && cd packages/sdk-socket-server-next && cd ../.. && yarn workspaces foreach --exclude @metamask/sdk-ui --verbose run build:pre-tsc && yarn workspaces foreach --exclude @metamask/sdk-ui --verbose --topological --parallel --no-private run build && yarn workspaces foreach --exclude @metamask/sdk-ui --verbose run build:post-tsc",
"light-build:clean": "yarn clean && yarn light-build",
"build:tsc": "tsc --build --force tsconfig.json",
"changelog:update": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run changelog:update",
"changelog:validate": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run changelog:validate",
"changelog:format": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run changelog:format",
"clean": "yarn workspaces foreach --no-private run clean",
"postinstall": "patch-package",
"link-packages": "./scripts/link-packages.sh",
"prepare": "husky install",
"dev:core": "turbo run dev --parallel --filter=@metamask/sdk-communication-layer --filter=@metamask/sdk --filter=@metamask/sdk-react",
"lint": "yarn workspaces foreach --no-private run lint",
"lint:changelogs": "yarn workspaces foreach --no-private run lint:changelog",
"lint:eslint": "yarn workspaces foreach --no-private run lint:eslint",
"lint:fix": "yarn workspaces foreach --no-private run lint:fix",
"lint:misc": "yarn workspaces foreach --no-private run lint:misc",
Expand Down Expand Up @@ -68,7 +70,7 @@
"@commitlint/config-conventional": "^17.6.7",
"@lavamoat/allow-scripts": "^2.3.1",
"@metamask/auto-changelog": "^3.4.3",
"@metamask/create-release-branch": "^1.0.1",
"@metamask/create-release-branch": "^4.1.3",
"@metamask/eslint-config": "^8.0.0",
"@metamask/eslint-config-jest": "^8.0.0",
"@metamask/eslint-config-nodejs": "^8.0.0",
Expand All @@ -89,7 +91,7 @@
"jest": "^29.6.4",
"lint-staged": "^13.2.3",
"patch-package": "^6.4.7",
"prettier": "^2.3.2",
"prettier": "^3.3.3",
"rimraf": "^3.0.2",
"serve": "^14.2.1",
"ts-jest": "^29.0.3",
Expand Down
4 changes: 3 additions & 1 deletion packages/devnext/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@
"dev": "next dev -p 3333",
"build": "next build",
"start": "next start",
"changelog:update": "../../scripts/update-changelog.sh devnext",
"changelog:validate": "../../scripts/validate-changelog.sh devnext",
"changelog:format": "../../scripts/format-changelog.sh devnext",
"lint": "yarn lint:eslint",
"lint:changelog": "../../scripts/validate-changelog.sh @metamask/sdk",
"lint:eslint": "eslint . --cache --ext js,ts,tsx",
"lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write",
"lint:misc": "prettier '**/*.json' '**/*.md' '!CHANGELOG.md' --ignore-path ../../.gitignore",
Expand Down
1 change: 0 additions & 1 deletion packages/devsocket/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
},
"devDependencies": {
"@lavamoat/allow-scripts": "^2.3.1",
"@metamask/auto-changelog": "^2.3.0",
"@metamask/eslint-config-jest": "^12.1.0",
"@metamask/eslint-config-typescript": "^6.0.0",
"@types/analytics-node": "^3.1.13",
Expand Down
12 changes: 12 additions & 0 deletions packages/sdk-analytics/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Changelog

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
Expand All @@ -7,27 +8,38 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]

## [0.0.5]

### Fixed

- Updates and Fixes to Analytics ([#1294](https://github.com/MetaMask/metamask-sdk/pull/1294))

## [0.0.4]

### Fixed

- Refactor sdk-analytics ([#1288](https://github.com/MetaMask/metamask-sdk/pull/1288))

## [0.0.3]

### Fixed

- fix: add publishConfig too release for sdk-analytics package ([#1284](https://github.com/MetaMask/metamask-sdk/pull/1284))

## [0.0.2]

### Added

- Add New Analytics Client ([#1270](https://github.com/MetaMask/metamask-sdk/pull/1270))

### Fixed

- fix: correct sdk analytics lint issued and package scope fix ([#1281](https://github.com/MetaMask/metamask-sdk/pull/1281))
- fix: make the package public ([#1279](https://github.com/MetaMask/metamask-sdk/pull/1279))

## [0.0.0]

### Added

- Initial release

[Unreleased]: https://github.com/MetaMask/metamask-sdk/compare/@metamask/[email protected]
Expand Down
5 changes: 3 additions & 2 deletions packages/sdk-analytics/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,16 @@
"types": "dist/index.d.ts",
"scripts": {
"build": "tsup src/index.ts --dts --format esm,cjs",
"changelog:update": "../../scripts/update-changelog.sh @metamask/sdk-analytics",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/sdk-analytics",
"changelog:format": "../../scripts/format-changelog.sh @metamask/sdk-analytics",
"lint": "eslint src --ext .ts,.tsx --ignore-pattern 'src/schema.ts'",
"lint:fix": "eslint src --ext .ts,.tsx --fix --ignore-pattern 'src/schema.ts'",
"lint:changelog": "../../scripts/validate-changelog.sh @metamask/sdk-analytics",
"test": "vitest",
"test:ci": "vitest --run",
"allow-scripts": ""
},
"devDependencies": {
"@metamask/auto-changelog": "^3.4.3",
"@metamask/eslint-config": "^14.0.0",
"@metamask/eslint-config-typescript": "^14.0.0",
"@typescript-eslint/eslint-plugin": "^8.31.0",
Expand Down
Loading
Loading