--skip-product-validation should probably return SKIP status

[rgdeen]

Checked for duplicates

Yes - I've already checked

🧑‍🔬 User Persona(s)

node operator

💪 Motivation

When running bundle referential integrity check, I have --skip-content-validation and --skip-product-validation.

It has a results section for product_val anyway, presumably it's just loading the labels which is fine. But it says PASS:

{
  "title": "PDS Validation Tool Report",
  "configuration": {
    "version": "3.7.1",
    "date": "2025-11-24T21:25:50Z"
  },
  "parameters": {
    "targets": "[file:/mnt/mars2020/release14/bundle/mars2020_cachecam_ops_raw/]",
    "ruleType": "pds4.bundle",
    "severityLevel": "ERROR",
    "recurseDirectories": "true",
    "fileFiltersUsed": "[*.xml, *.XML]",
    "dataContentValidation": "off",
    "productLevelValidation": "off",
    "allowUnlabeledFiles": "false",
    "maxErrors": "100000",
    "registeredContextsFile": "/mnt/mars2020/validate/validate-3.7.1/resources/registered_context_products.json"
  },
  "productLevelValidationResults": [
    {
      "status": "PASS",
      "label": "file:/mnt/mars2020/release14/bundle/mars2020_cachecam_ops_raw/bundle.xml",
      "messages": [],
      "fragments": [],
      "dataContents": []
    },
    {
      "status": "PASS",
      "label": "file:/mnt/mars2020/release14/bundle/mars2020_cachecam_ops_raw/data/collection_data.xml",
      "messages": [],
      "fragments": [],
      "dataContents": []
    },
    {
      "status": "PASS",
      "label": "file:/mnt/mars2020/release14/bundle/mars2020_cachecam_ops_raw/data/sol/01552/ids/edr/cachecam/CCE_1552_0804739418_223EDRUN0770000CACH00230_04_0LLJ01.xml",
      "messages": [],
      "fragments": [],
      "dataContents": []
    },
...

Later it gets to the bundle check and says PASS again:

  "pDS4BundleLevelValidationResults": [
    {
      "status": "PASS",
      "label": "file:/mnt/mars2020/release14/bundle/mars2020_cachecam_ops_raw/browse/collection_browse.xml",
      "messages": [],
      "fragments": [],
      "dataContents": []
    },
    {
      "status": "PASS",
      "label": "file:/mnt/mars2020/release14/bundle/mars2020_cachecam_ops_raw/data/collection_data.xml",
      "messages": [],
      "fragments": [],
      "dataContents": []
    },
...

The summary shows this:

  "summary": {
    "totalProducts": 911,
    "totalErrors": 0,
    "totalWarnings": 0,
    "productValidation": {
      "passed": "0",
      "failed": "0",
      "skipped": "911",
      "total": "911"
    },
    "referentialIntegrity": {
      "passed": "911",
      "failed": "0",
      "skipped": "0",
      "total": "911"
    },
    "messageTypes": []
  }

So I get that you have to load them all in the first pass. But the summary says passed:0 and skipped:911. Shouldn't the individual status of each item be "SKIP" then rather than PASS?

The RI section is fine, it has 911 passes which is good.

📖 Additional Details

Not quite sure if this is a feature or a bug.

I know I've had a similar complaint before but couldn't find the ticket. Perhaps that ticket is what gave us skipped in the summary? In any case, the discrepancy between the summary and details is not good.

Acceptance Criteria

Given
When I perform
Then I expect

⚙️ Engineering Details

Categorizing this ticket as could-have / low severity since it could be fixed in an ideal world, but will be tabled for the time being. Will update documentation in the meantime to address this concern.

🎉 I&T

No response