Skip to content

Conversation

@sjvrijn
Copy link
Contributor

@sjvrijn sjvrijn commented Nov 16, 2025

Checklist before requesting a review

  • I have read the contribution guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • All user facing changes have been added to CHANGELOG.md

Type of change

  • New feature (non-breaking change which adds functionality)

List of related issues or pull requests

Refs:

Describe the changes made in this pull request

  • Update the list of supported Python versions to include 3.13 and 3.14
  • Update CI actions to use 3.14 instead of 3.12

Instructions to review the pull request

Warning

Running the template's tox test locally runs into issues if your Python versions are installed through uv since they don't contain pip. See this thread for details.

Install the requirements

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
pip install pipx
pipx install copier

Create a new package using the template

copier copy --vcs-ref 702-support-314 https://github.com/nlesc/python-template test_package

Create a local git repo to push to GitHub to trigger CI actions

git init
git add --all
git commit -m "First commit"
git remote add origin [email protected]:<YOU>/python-template-test.git
git push -u origin main -f

@sjvrijn sjvrijn force-pushed the 702-support-314 branch 2 times, most recently from 8f9d7d6 to 504d217 Compare November 22, 2025 17:39
@sjvrijn sjvrijn marked this pull request as ready for review November 23, 2025 15:27
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me @sjvrijn! Should we also drop support for the older Python versions 3.10 and 3.11, as recommended by SPEC-0, to avoid making the build matrix rather large by default and causing unnecessary use of resources?

Copy link
Member

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I create a package from the template, (thanks for the instructions). And was able to run the pytest/doc build/build with Python 3.14 via uv.

I agree with @bouweandela lets drop Python 3.10 and 3.11 from at least the CI workflows.

@sjvrijn
Copy link
Contributor Author

sjvrijn commented Nov 27, 2025

@bouweandela @sverhoeven Good point, I'll at least remove 3.10 and 3.11 from the CI matrix.
I'll also think a bit about where to document that we're following this SPEC 0 guidance, before the change gets undone at some point in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants