Fix evolve_async missing return and incorrect condition check #3636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fixes in evolution.py: - Fix missing return statement in evolve_single_async when collapse_operators is provided with store_intermediate_results=NONE mode - Fix condition check: use 'store_intermediate_results != NONE' instead of boolean check on enum value Test improvements: - Fix expectation_values() access pattern in test to correctly handle nested list structure - Fix intermediate_states() assertion: NONE mode returns 1 (final state only) - Add test_evolve_no_intermediate_results for sync version coverage Signed-off-by: huaweil <[email protected]>
huaweil-nv
force-pushed
the
evolve-none-mode-tests
branch
from
b5620bc to
30a0e00
Compare
Collaborator
Command Bot: Processing... |
1tnguyen
approved these changes
Nov 25, 2025
Collaborator
1tnguyen
left a comment
1tnguyen
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks @huaweil-nv!
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When checking the coverage of evolution.py (http://porting-server/cuda-quantum/20250924/cudaq/pycoverage/python--cudaq--dynamics--evolution.py.html#t570), it was found that this part of the test is missing.
Bug fixes in evolution.py:
Test improvements: