-
Notifications
You must be signed in to change notification settings - Fork 2k
Radiance Field Loss / Many worlds #1601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @Tom94, This is ready in my opinion.
|
Tom94
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you very much!
Did you want to add some info about the new modes to the readme and link to your paper? I think it'd be great if users could discover these significant improvements easily.
We should also consider making RflRelax the default -- could you remind me whether you saw any scenes where it hurt the reconstruction at ~equal training time more than it helped?
|
Thanks for the feedback. I have handled all small issues and added more comments. I have set Rfl-Relax as default. To ensure performance remains at least as good as NeRF, I used a very conservative training strategy:
MipNeRF360 tests still show ~2x rendering speedup vs NeRF. The conservative approach costs us ~20% performance compared to full RFL, but good enough. We could definitely make it more robust and squeeze out more performance. But IMO this hybrid reconstruction approach still needs more research and has many unexplored potentials, so probably I shouldn't overdo it for now. |
include/neural-graphics-primitives/fused_kernels/train_nerf.cuh
Outdated
Show resolved
Hide resolved
|
Thanks again -- it's great to have the radiance field loss be officially part of instant NGP! I'll be doing some testing in the coming days and then put more info into the readme + probably push a release. :) |
|
Hi @ziyi-zhang and @Tom94 do you guys have an instructions on how to turn on radiance field loss (RFL) that can matches the settings in the paper ? |
This PR introduces new training modes that promote radiance surface representations.
For research code used in the paper, please check this repo.
This PR should not change any existing behavior unless users explicitly enable the new training modes.
New features
[x] Add RFL and a relaxed variant in JIT training mode.
[x] Support surface rendering in JIT rendering mode.
[x] Non-JIT mode RFL training will not be supported as it is significantly slower.
Performance