Fix systematical typo: treshold -> threshold

Author: nvolk

src/cli.js

@@ -55,7 +55,7 @@ async function cli() {
   debug(JSON.stringify(args));
 
   const detection = {
-    treshold: 0.9,
+    threshold: 0.9,
     strategy: generateStrategy(searchType)
   };
 

src/index.js

@@ -124,7 +124,7 @@ export default ({detection: detectionOptions, search: searchOptions, maxMatches
     // - candidate.record
     // - probability
     // - strategy (if returnStrategy option is true)
-    // - treshold (if returnStrategy option is true)
+    // - threshold (if returnStrategy option is true)
     // - matchQuery (if returnQuery option is true)
     // failures: array of conversionFailures from candidate-search and matchErrors from matchDetection in error format {status, payload: {message, id}} if returnFailures is true
 
@@ -257,7 +257,7 @@ export default ({detection: detectionOptions, search: searchOptions, maxMatches
 
         if (detectionResult.match || returnNonMatches) {
           debug(`${detectionResult.match ? `Record ${candidateId} (${newRecordCount}/${recordSetSize}) is a match!` : `Record ${candidateId} (${newRecordCount}/${recordSetSize}) is NOT a match!`}`);
-          debugData(`Strategy: ${JSON.stringify(detectionResult.strategy)}, Treshold: ${JSON.stringify(detectionResult.treshold)}`);
+          debugData(`Strategy: ${JSON.stringify(detectionResult.strategy)}, Threshold: ${JSON.stringify(detectionResult.threshold)}`);
 
           const matchResult = {
             probability: detectionResult.probability,
@@ -268,7 +268,7 @@ export default ({detection: detectionOptions, search: searchOptions, maxMatches
           };
           const strategyResult = {
             strategy: detectionResult.strategy,
-            treshold: detectionResult.treshold
+            threshold: detectionResult.threshold
           };
           const newMatch = returnStrategy ? {...matchResult, ...strategyResult} : {...matchResult};
 

src/match-detection/features/bib/authors.js

@@ -6,7 +6,7 @@ import {testStringOrNumber} from '../../../matching-utils.js';
 
 // We should extract also organisational authors (110/710)
 
-export default ({nameTreshold = 10} = {}) => ({
+export default ({nameThreshold = 10} = {}) => ({
   name: 'Authors',
   extract: ({record}) => {
     //const label = recordExternal && recordExternal.label ? recordExternal.label : 'record';
@@ -58,7 +58,7 @@ export default ({nameTreshold = 10} = {}) => ({
         const maxLength = getMaxLength();
         const percentage = distance / maxLength * 100;
 
-        return percentage <= nameTreshold;
+        return percentage <= nameThreshold;
 
         function getMaxLength() {
           return a.length > b.length ? a.length : b.length;

src/match-detection/features/bib/title-version-original.js

@@ -3,7 +3,7 @@ import createDebugLogger from 'debug';
 import naturalPkg from 'natural';
 const {LevenshteinDistance: leven} = naturalPkg;
 
-export default ({treshold = 10} = {}) => ({
+export default ({threshold = 10} = {}) => ({
   name: 'titleVersionOriginal',
   extract: ({record}) => {
     const title = getTitle();
@@ -38,7 +38,7 @@ export default ({treshold = 10} = {}) => ({
 
     debug(`'${a}' vs '${b}': Max length = ${maxLength}, distance = ${distance}, percentage = ${percentage}`);
 
-    if (percentage <= treshold) {
+    if (percentage <= threshold) {
       return 0.3;
     }
 

src/match-detection/features/bib/title.js

@@ -7,7 +7,7 @@ const debug = createDebugLogger('@natlibfi/melinda-record-matching:match-detecti
 const debugData = debug.extend('data');
 
 
-export default ({treshold = 10} = {}) => ({
+export default ({threshold = 10} = {}) => ({
   name: 'Title',
   extract: ({record, recordExternal}) => {
     const label = recordExternal && recordExternal.label ? recordExternal.label : 'record';
@@ -56,7 +56,7 @@ export default ({treshold = 10} = {}) => ({
 
     debug(`'${a}' vs '${b}': Max length = ${maxLength}, distance = ${distance}, percentage = ${percentage}`);
 
-    if (percentage <= treshold) {
+    if (percentage <= threshold) {
       return 0.3;
     }
 

src/match-detection/index.js

@@ -4,13 +4,13 @@ import * as features from './features/index.js';
 
 export {features};
 
-export default ({strategy, treshold = 0.9}, returnStrategy = false, localSettings = {}) => ({recordA, recordB, recordAExternal = {}, recordBExternal = {}}) => {
+export default ({strategy, threshold = 0.9}, returnStrategy = false, localSettings = {}) => ({recordA, recordB, recordAExternal = {}, recordBExternal = {}}) => {
   const minProbabilityQuantifier = 0.5;
 
   const debug = createDebugLogger('@natlibfi/melinda-record-matching:match-detection');
   const debugData = debug.extend('data');
 
-  debugData(`Strategy: ${JSON.stringify(strategy)}, Treshold: ${JSON.stringify(treshold)}, ReturnStrategy: ${JSON.stringify(returnStrategy)}`);
+  debugData(`Strategy: ${JSON.stringify(strategy)}, Threshold: ${JSON.stringify(threshold)}, ReturnStrategy: ${JSON.stringify(returnStrategy)}`);
   debugData(`Records: A: ${recordA}\nB: ${recordB}`);
   debug(`Externals: A: ${JSON.stringify(recordAExternal)}, B: ${JSON.stringify(recordBExternal)}`);
   // We could add here labels for records if we didn't get external labels
@@ -43,8 +43,8 @@ export default ({strategy, treshold = 0.9}, returnStrategy = false, localSetting
 
     if (similarityVector.some(v => v >= minProbabilityQuantifier)) {
       const probability = calculateProbability(similarityVector);
-      debug(`probability: ${probability} (Treshold: ${treshold})`);
-      return returnResult({match: probability >= treshold, probability});
+      debug(`probability: ${probability} (Threshold: ${threshold})`);
+      return returnResult({match: probability >= threshold, probability});
     }
 
     debugData(`No feature yielded minimum probability amount of points (${minProbabilityQuantifier})`);
@@ -58,7 +58,7 @@ export default ({strategy, treshold = 0.9}, returnStrategy = false, localSetting
   function returnResult(result) {
     if (returnStrategy) {
       debug(`Returning detection strategy with the result`);
-      const resultWithStrategy = {match: result.match, probability: result.probability, strategy: formatStrategy(strategy), treshold};
+      const resultWithStrategy = {match: result.match, probability: result.probability, strategy: formatStrategy(strategy), threshold};
       debugData(`${JSON.stringify(resultWithStrategy)}`);
       return resultWithStrategy;
     }

test-fixtures/index/10/expectedMatches.json

@@ -5,7 +5,7 @@
       "Title",
       "ISBN"
     ],
-    "treshold": 0.9,
+    "threshold": 0.9,
     "candidate": {
       "id": "000019641",
       "record": {

test-fixtures/index/10/expectedNonMatches.json

@@ -5,7 +5,7 @@
       "Title",
       "ISBN"
     ],
-    "treshold": 0.9,
+    "threshold": 0.9,
     "candidate": {
       "id": "000019642",
       "record": {

test-fixtures/match-detection/features/bib/title-version-original/04/metadata.json

@@ -1,5 +1,5 @@
 {
-  "description": "Comparison should return points for matching titles (Different values, distance under treshold)",
+  "description": "Comparison should return points for matching titles (Different values, distance under threshold)",
   "feature": "titleVersionOriginal",
   "type": "compare",
   "expectedPoints": 0.3,

test-fixtures/match-detection/features/bib/title/c-02/metadata.json

@@ -1,5 +1,5 @@
 {
-  "description": "Comparison should return plus points for matching titles (Different values, distance under treshold)",
+  "description": "Comparison should return plus points for matching titles (Different values, distance under threshold)",
   "feature": "title",
   "type": "compare",
   "expectedPoints": 0.3,