fix: reporting fields per spec #349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
@Koenkk can you take a look (I've based the branch on the other pending PR but split it for easier review)? Also should probably make a note in the next release note that the field not being present is actually expected behavior (no longer hides the fact the field is ignored automatically by herdsman when data type not analog). PS: the github diff made a mess again, best to see changes in vscode...
I think this
The sign (if any) of the reportable change field is ignored.is also worth investigating (for ZH)TODO: