-
Notifications
You must be signed in to change notification settings - Fork 1
Add type hints and restyle docstrings #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mary-cleaton
wants to merge
18
commits into
develop
Choose a base branch
from
fix/add-type-hints
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Had coded this using the union object |. However, this was added in Python 3.10 and this repo currently still uses Python 3.8 and 3.9. Hence, revert to using typing.Union. Once this repo no longer supports these versions of Python, this can be changed back to using the union object (which is less verbose and easier to read).
Contributor
Author
|
Wait til #63 merged, then rebase and add type hints to run script. Then, this can be published and ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
pyspark
Pull requests that update pyspark code
python
Pull requests that update python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add type hints to all functions. In particular, please can you check:
pyspark.sql.SparkSessionnotspark.sql.SparkSession).cutpointsis alwaysDict[str, Union[List[float], None]]),input_variablesis alwaysDict[str, Any]).I have also standardised the docstrings, where I noticed that they were non-standard, and updated the docstring styling (mostly by reducing the indent to two spaces from four, to reduce file length). Standardising the docstrings included standardising subheading order, which as per our chosen style should be:
Type of change
Checklist:
Peer review
Any new code includes all the following:
Review comments
Suggestions should be tailored to the code that you are reviewing. Provide context.
Be critical and clear, but not mean. Ask questions and set actions.
These might include:
that it is likely to interact with?)
works correctly? Are there additional edge cases/ negative tests to be considered?
Further reading: code review best practices