-
Notifications
You must be signed in to change notification settings - Fork 3
CI: actions/checkout v4 to v5 #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughUpdated the CI workflow Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.github/workflows/main.yml (3)
13-13: Upgrade to checkout v5: good; verify runner requirement and consider pinning.
- v5 runs on Node 24 and requires Actions Runner v2.327.1+. GitHub‑hosted ubuntu‑latest should already meet this; if you use any self‑hosted runners, confirm they’re ≥ v2.327.1. (github.com)
- Optional hardening: pin to a full commit SHA to avoid tag mutability. (docs.github.com)
Example pin (replace with the release’s SHA):
- - uses: actions/checkout@v5 + - uses: actions/checkout@<full-commit-sha> # v5.x.y
15-17: Upgrade pnpm/action-setup to v4.v2 is deprecated/broken on newer Node versions; v4 is the maintained line. (github.com)
- - uses: pnpm/action-setup@v2 + - uses: pnpm/action-setup@v4 with: version: 10
31-35: Use github_token input for gh-pages when passing GITHUB_TOKEN.It’s clearer and matches the action’s documented inputs. Functionally equivalent here. (github.com)
- uses: peaceiris/actions-gh-pages@v4 - with: - publish_dir: ./docs - personal_token: ${{ secrets.GITHUB_TOKEN }} - force_orphan: true + uses: peaceiris/actions-gh-pages@v4 + with: + publish_dir: ./docs + github_token: ${{ secrets.GITHUB_TOKEN }} + force_orphan: true
Summary by CodeRabbit