Skip to content

Commit 94e7cd3

Browse files
committed
[CI] Fail if any notebook fails
Part of OpenAssetIO/OpenAssetIO#1302. The CI job that checks if notebooks can be executed was expected to fail until upstream OpenAssetIO changes were available, however the job succeeded. Upon checking the logs we can see the failure of the new notebook, but the job finished without error. It seems that `find -exec` doesn't error. Signed-off-by: David Feltell <[email protected]>
1 parent dc8b9bd commit 94e7cd3

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

.github/workflows/examples.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,11 @@ jobs:
3434
# Execute all the notebooks apart from the Hybrid Plugin System,
3535
# which requires a build of SimpleCppManager
3636
run: >
37-
find examples -maxdepth 1 -name "*.ipynb"
38-
! -name "hybrid_plugin_system.ipynb"
39-
-exec jupyter nbconvert --to html --execute {} \;
37+
for notebook in examples/*.ipynb; do
38+
[[ "$notebook" == *"hybrid_plugin_system.ipynb" ]] && continue
39+
echo "Executing $notebook..."
40+
jupyter nbconvert --to html --execute "$notebook"
41+
done
4042
4143
test-cpp-notebooks:
4244
# A special job just for the Hybrid Plugin System because it needs a

0 commit comments

Comments
 (0)