Update README CMake instructions to include Python by default #112
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CI will fail until #113 is merged. |
hutchinson
approved these changes
Apr 1, 2025
It turns out in practice that users usually want both the C++ and Python component when generating the trait library using CMake. There was no mention that the Python component must be enabled using a CMake variable. So add a small tweak to the README so that the default instructions enable the Python component. Signed-off-by: David Feltell <[email protected]>
feltech
force-pushed
the
work/readmeCppCmakeIncludePython
branch
from
4257a64 to
9d44457
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out in practice that users usually want both the C++ and Python component when generating the trait library using CMake. There was no mention that the Python component must be enabled using a CMake variable.
So add a small tweak to the README so that the default instructions enable the Python component.