editoast: use 'Borrow' to avoid iteration in 'HashSet' #13940
+13
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean SIMARD <[email protected]>
Wadjetz
approved these changes
Nov 12, 2025
leovalais
approved these changes
Nov 12, 2025
Contributor
leovalais
left a comment
leovalais
left a comment
There was a problem hiding this comment.
Looks fun, a bit worried about the raw strings where typos can result in annoying bugs. Maybe we could define constants and use them instead? But I'm fine without as well :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a
HashSetis based on aHashMap<T, ()>, values in theHashSetare indexed. Therefore, we shouldn't need to iterate in theHashSetto find a value. The problem is that we would need a fullEtcsLevel2value with the correctbrake_paramsto find it. But thanks to theBorrowtrait, we don't need a fullSupportingSignalingSystemfor finding, we can tell to only find based on the variant, not the content of the variant. And in our case, it actually makes a lot of sense since we do ignore the payload from theHashimplementation.