front: allow users to copy and paste timetables #13943
Conversation
MartinBourbier
force-pushed
the
mbr/copy-paste-timetables
branch
from
7c7b708 to
f4ebfc7
Compare
| if (!timetableItems) return; | ||
|
|
||
| const jsonString = timetableItemsToJson(selectedTimeTableIdsFromClick, timetableItems); | ||
| navigator.clipboard.writeText(jsonString); |
There was a problem hiding this comment.
Could we use ClipboardItem + clipboard.write() instead of text, to indicate that a JSON blob is being copied? Could also set disposition as attachment.
There was a problem hiding this comment.
Unfortunately from what I saw, the clipboard doesn't support writing JSON, it can only write plain text, html or png. :(
There was a problem hiding this comment.
Hm, what do you mean? Does it throw an error? Does it silently do nothing?
There was a problem hiding this comment.
It throw an error (DOMException with not supported type to be more specific).
There was a problem hiding this comment.
Ah right, ClipboardItem.supports('application/json') returns false… It seems like we'd need to use a custom web MIME type if we wanted to assign a different MIME type…
|
|
||
| const ctrlV = useCallback( | ||
| async (event: KeyboardEvent) => { | ||
| if (!event.repeat && event.ctrlKey && event.key === 'v') { |
There was a problem hiding this comment.
Could we use the paste event instead of catching a specific combination of keypresses?
|
|
||
| const ctrlC = useCallback( | ||
| (event: KeyboardEvent) => { | ||
| if (!event.repeat && event.ctrlKey && event.key === 'c') { |
There was a problem hiding this comment.
I think we can use the copy event here instead too (together with event.preventDefault() to disable the built-in copy behavior).
ppitou
force-pushed
the
mbr/copy-paste-timetables
branch
from
f4ebfc7 to
c11bacc
Compare
Signed-off-by: Martin Bourbier <[email protected]>
Signed-off-by: Martin Bourbier <[email protected]>
Signed-off-by: Angelina Kuntz <[email protected]>
…g (ctrl+x) Signed-off-by: Angelina Kuntz <[email protected]>
MartinBourbier
force-pushed
the
mbr/copy-paste-timetables
branch
from
e1d1f08 to
1b945a3
Compare
Signed-off-by: Martin Bourbier <[email protected]>
MartinBourbier
force-pushed
the
mbr/copy-paste-timetables
branch
from
1b945a3 to
0cbf0ea
Compare
This PR allows users to copy and paste timetables using simple standard shortcuts (ctrl+c, ctrl+v, ctrl+x).
Closes #13902