Skip to content

Conversation

@Sebastian-Maier
Copy link
Contributor

@Sebastian-Maier Sebastian-Maier commented Aug 18, 2025

Similar to PR OpenVoxProject/container-openvoxserver#59 that addressed issue OpenVoxProject/container-openvoxserver#56 for container-openvoxserver, this PR brings vendor-agnostic "container" terminology to container-openvoxdb instead of "Docker" (in a backwards-compatible fashion):

  • introduces container-entrypoint.sh that supports custom scripts in both /docker-custom-entrypoint.d/ and /container-custom-entrypoint.d/ directories
  • adjusts docker-entrypoint.sh to print a deprecation warning and call container-entrypoint.sh
  • adjusts documentation accordingly

@nsballmann
Copy link

LGTM 👌

@Sebastian-Maier Sebastian-Maier marked this pull request as ready for review August 18, 2025 11:31
@Sebastian-Maier Sebastian-Maier requested a review from a team as a code owner August 18, 2025 11:31
@Sebastian-Maier Sebastian-Maier force-pushed the refactor/container-entrypoint branch from 5d42cce to 8433950 Compare August 18, 2025 11:37
@rwaffen rwaffen merged commit ddf9d4e into OpenVoxProject:main Aug 18, 2025
9 checks passed
@rwaffen rwaffen added the enhancement New feature or request label Aug 18, 2025
@nsballmann
Copy link

@Sebastian-Maier thank you for taking care.

@rwaffen thank you for the fast review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants