refactor(app): Update zipfile timestamp to reflect robot-server filenames (#20070)

Author: mjhuff

app/src/organisms/Desktop/Devices/HistoricalProtocolRunDrawer.tsx

@@ -390,9 +390,9 @@ function ImagesFileDataRow({
     robotType: robotType,
   })
   const { data: imagesZipFile, isLoading } = useAllRunImagesRaw(run.id)
-  const runTimestamp = format(new Date(run.createdAt), 'M/d/yy_HH:mm:ss')
+  const formattedRunTs = format(new Date(run.createdAt), 'yyyyMMdd-HHmmss')
   const buildImagesZipName = (): string =>
-    `${robotName}_${protocolName}_${runTimestamp}_${t('images')}.zip`
+    `${robotName}_${protocolName}_${formattedRunTs}_${t('images')}.zip`
 
   return (
     <Flex
@@ -415,7 +415,7 @@ function ImagesFileDataRow({
         </LegacyStyledText>
       </Flex>
       <Box width="33%">
-        <LegacyStyledText as="p">{runTimestamp}</LegacyStyledText>
+        <LegacyStyledText as="p">{formattedRunTs}</LegacyStyledText>
       </Box>
       <Box width="34%">
         <Link

app/src/organisms/Desktop/Devices/ProtocolRun/ProtocolRunCamera/ImageGalleryContainer/GalleryContainerOverflowMenu.tsx

@@ -50,7 +50,15 @@ export function GalleryContainerOverflowMenu({
     source: SOURCE_RUN_RECORD,
     robotType,
   })
-  const formattedRunTs = format(new Date(runTimestamp), 'M/d/yy_HH:mm:ss')
+  const formattedRunTs = (() => {
+    try {
+      if (runTimestamp == null) return ''
+      return format(new Date(runTimestamp), 'yyyyMMdd-HHmmss')
+    } catch (error) {
+      console.warn('Invalid timestamp:', runTimestamp)
+      return ''
+    }
+  })()
   const buildImagesZipName = (): string =>
     `${robotName}_${protocolName}_${formattedRunTs}_${t('images')}.zip`
 

app/src/resources/dataFiles/useImageInfo.ts

@@ -49,13 +49,26 @@ export function useImageInfo(runId: string): UseImagesInfoResult {
   )
   const items = useMemo(() => {
     if (data == null) return []
-    return data.data.map(img => ({
-      imageId: img.id,
-      filename: img.filename,
-      stepCommandId: img.commandId ?? '',
-      previousStepCommandId: img.prevCommandId ?? '',
-      timestamp: format(new Date(String(img.createdAt)), 'M/d/yy HH:mm:ss'),
-    }))
+
+    return data.data.map(img => {
+      const timestamp = (() => {
+        try {
+          if (img?.createdAt == null) return ''
+          return format(new Date(String(img.createdAt)), 'M/d/yy HH:mm:ss')
+        } catch (error) {
+          console.warn('Invalid timestamp:', img?.createdAt)
+          return ''
+        }
+      })()
+
+      return {
+        imageId: img.id,
+        filename: img.filename,
+        stepCommandId: img.commandId ?? '',
+        previousStepCommandId: img.prevCommandId ?? '',
+        timestamp,
+      }
+    })
   }, [data])
   return { items, protocolAnalysis, isLoadingImages, allRunDefs }
 }