fix(pd): remove cypress (#20207)

Author: y3rsh

.github/workflows/pd-test-build-deploy.yaml

@@ -83,29 +83,12 @@ jobs:
           flags: protocol-designer
           token: ${{ secrets.CODECOV_TOKEN }}
 
-  e2e-test:
-    name: 'protocol designer e2e tests'
-    runs-on: 'ubuntu-24.04'
-    timeout-minutes: 20
-    if: ${{ !startsWith(github.ref, 'refs/tags/') }}
-    steps:
-      - name: 'Checkout Repository'
-        uses: actions/checkout@v4
-        with:
-          fetch-depth: 0 # PD needs to see labware in other release branches
-      - uses: ./.github/actions/js/setup
-      - name: 'run test-e2e'
-        run: make -C protocol-designer test-e2e
-
   build-pd:
     timeout-minutes: 20
     name: 'build protocol designer'
     needs:
       - determine-deploy-config
-      - unit-test
-      - e2e-test
     runs-on: 'ubuntu-24.04'
-    if: always() && (needs.unit-test.result == 'success' || needs.unit-test.result == 'skipped') && (needs.e2e-test.result == 'success' || needs.e2e-test.result == 'skipped')
     steps:
       - uses: actions/checkout@v4
         with:
@@ -213,8 +196,8 @@ jobs:
   notify-success:
     name: 'Notify Build Success'
     runs-on: 'ubuntu-latest'
-    needs: [unit-test, e2e-test, build-pd, deploy-pd]
-    if: always() && github.event_name == 'push' && startsWith(github.ref, 'refs/tags/') && (needs.unit-test.result == 'success' || needs.unit-test.result == 'skipped') && (needs.e2e-test.result == 'success' || needs.e2e-test.result == 'skipped') && needs.build-pd.result == 'success' && needs.deploy-pd.result == 'success'
+    needs: [unit-test, build-pd, deploy-pd]
+    if: always() && github.event_name == 'push' && startsWith(github.ref, 'refs/tags/') && (needs.unit-test.result == 'success' || needs.unit-test.result == 'skipped') && needs.build-pd.result == 'success' && needs.deploy-pd.result == 'success'
     steps:
       - name: Checkout Repository
         uses: actions/checkout@v4
@@ -228,8 +211,8 @@ jobs:
   notify-failure:
     name: 'Notify Build Failure'
     runs-on: 'ubuntu-latest'
-    needs: [unit-test, e2e-test, build-pd, deploy-pd]
-    if: always() && github.event_name == 'push' && startsWith(github.ref, 'refs/tags/') && (needs.unit-test.result == 'failure' || needs.e2e-test.result == 'failure' || needs.build-pd.result == 'failure' || needs.deploy-pd.result == 'failure')
+    needs: [unit-test, build-pd, deploy-pd]
+    if: always() && github.event_name == 'push' && startsWith(github.ref, 'refs/tags/') && (needs.unit-test.result == 'failure' || needs.build-pd.result == 'failure' || needs.deploy-pd.result == 'failure')
     steps:
       - name: Checkout Repository
         uses: actions/checkout@v4
@@ -241,9 +224,6 @@ jobs:
           if [[ "${{ needs.unit-test.result }}" == "failure" ]]; then
             failed_jobs+=("unit-test")
           fi
-          if [[ "${{ needs.e2e-test.result }}" == "failure" ]]; then
-            failed_jobs+=("e2e-test")
-          fi
           if [[ "${{ needs.build-pd.result }}" == "failure" ]]; then
             failed_jobs+=("build-pd")
           fi
@@ -265,8 +245,8 @@ jobs:
   notify-cancelled:
     name: 'Notify Build Cancelled'
     runs-on: 'ubuntu-latest'
-    needs: [unit-test, e2e-test, build-pd, deploy-pd]
-    if: always() && github.event_name == 'push' && startsWith(github.ref, 'refs/tags/') && (needs.unit-test.result == 'cancelled' || needs.e2e-test.result == 'cancelled' || needs.build-pd.result == 'cancelled' || needs.deploy-pd.result == 'cancelled')
+    needs: [unit-test, build-pd, deploy-pd]
+    if: always() && github.event_name == 'push' && startsWith(github.ref, 'refs/tags/') && (needs.unit-test.result == 'cancelled' || needs.build-pd.result == 'cancelled' || needs.deploy-pd.result == 'cancelled')
     steps:
       - name: Checkout Repository
         uses: actions/checkout@v4

Makefile

@@ -196,7 +196,6 @@ test-windows: test-js test-py-windows
 .PHONY: test-e2e
 test-e2e:
 	$(MAKE) -C $(LABWARE_LIBRARY_DIR) test-e2e
-	$(MAKE) -C $(PROTOCOL_DESIGNER_DIR) test-e2e
 
 PYTHON_TEST_TARGETS := $(addsuffix -py-test, $(PYTHON_DIRS))
 WINDOWS_PYTHON_TEST_TARGETS := $(addsuffix -py-test, $(HARDWARE_DIR) $(API_DIR) $(SHARED_DATA_DIR)/python)

protocol-designer/Makefile

@@ -60,13 +60,6 @@ serve: export NODE_OPTIONS := --max-old-space-size=8192
 serve: all
 	vite preview
 
-# end to end tests
-.PHONY: test-e2e
-test-e2e: clean-downloads
-	concurrently --kill-others --success first --names "protocol-designer-server,protocol-designer-tests" \
-	"$(MAKE) dev" \
-	"wait-on http://localhost:5178/ && cypress run --browser chrome --headless --record false --quiet"
-
 .PHONY: test
 test:
 	$(MAKE) -C .. test-js-protocol-designer tests="$(tests)" test_opts="$(test_opts)"
@@ -75,51 +68,6 @@ test:
 test-cov:
 	make -C .. test-js-protocol-designer tests=$(tests) test_opts="$(test_opts)" cov_opts="$(cov_opts)"
 
-CYPRESS_ESLINT_GLOB := cypress/**/*.ts cypress.config.ts
-CYPRESS_PRETTIER_GLOB := cypress/**/*.{ts,md,json} cypress.config.ts
-
-.PHONY: cy-lint-check
-cy-lint-check: cy-lint-eslint-check cy-lint-prettier-check
-	@echo "Cypress lint check completed."
-
-.PHONY: cy-lint-fix
-cy-lint-fix: cy-lint-eslint-fix cy-lint-prettier-fix
-	@echo "Cypress lint fix applied."
-
-.PHONY: cy-lint-eslint-check
-cy-lint-eslint-check: clean-downloads clean-screenshots
-	yarn eslint --ignore-path ../.eslintignore $(CYPRESS_ESLINT_GLOB)
-	@echo "Cypress ESLint check completed."
-
-.PHONY: cy-lint-eslint-fix
-cy-lint-eslint-fix: clean-downloads clean-screenshots
-	yarn eslint --fix --ignore-pattern ../.eslintignore $(CYPRESS_ESLINT_GLOB)
-	@echo "Cypress ESLint fix applied."
-
-.PHONY: cy-lint-prettier-check
-cy-lint-prettier-check: clean-downloads clean-screenshots
-	yarn prettier --ignore-path ../.eslintignore --check $(CYPRESS_PRETTIER_GLOB)
-	@echo "Cypress Prettier check completed."
-
-.PHONY: cy-lint-prettier-fix
-cy-lint-prettier-fix: clean-downloads clean-screenshots
-	yarn prettier --ignore-path ../.eslintignore --write $(CYPRESS_PRETTIER_GLOB)
-	@echo "Cypress Prettier fix applied."
-
-.PHONY: cy-ui
-cy-ui:
-	@echo "Running Cypress UI"
-	@echo "Dev environment must be running"
-	yarn cypress open
-
-.PHONY: clean-downloads
-clean-downloads:
-	shx rm -rf cypress/downloads
-
-.PHONY: clean-screenshots
-clean-screenshots:
-	shx rm -rf cypress/screenshots
-
 # analyze bundle
 .PHONY: bundle-analyzer
 bundle-analyzer: