Skip to content

Conversation

@CaseyBatten
Copy link
Contributor

@CaseyBatten CaseyBatten commented Nov 10, 2025

Overview

Covers RQA-4842

Ensures we execute error image capture even if the original exception that prompted image capture gets interrupted by another exception.

Test Plan and Hands on Testing

  • On an OT-2 trigger a smoothie error via collision and ensure an image is still captured.
  • Test with Flex Estop
  • Test with protocol cancelation

Changelog

Changed called for image capture via error to a finally case.

Review requests

Should this cover us, or should this be relocated away from the CommandExecutor entirely incase external errors interrupt us? Would we even want a photo from one of those?

Risk assessment

Low - reinforces new behavior.

@CaseyBatten CaseyBatten changed the base branch from edge to chore_release-8.8.0 November 10, 2025 21:16
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine; do me a favor and test it with a flex estop and some cancels, those are the only ones i worry about

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants