fix(api): Capture images on error even when exception is interrupted #20107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Covers RQA-4842
Ensures we execute error image capture even if the original exception that prompted image capture gets interrupted by another exception.
Test Plan and Hands on Testing
Changelog
Changed called for image capture via error to a
finallycase.Review requests
Should this cover us, or should this be relocated away from the
CommandExecutorentirely incase external errors interrupt us? Would we even want a photo from one of those?Risk assessment
Low - reinforces new behavior.