Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented Nov 11, 2025

Overview

update electron version to v39

close AUTH-2482

Test Plan and Hands on Testing

maybe needed to run the following

./node_modules/.bin/electron-rebuild

Changelog

  • update Electron version v33 -> v39
  • update nodejs 22.12.0 -> 22.21.1 and update package.json
  • update nodejs version in CI

Review requests

Risk assessment

low

@koji
Copy link
Contributor Author

koji commented Nov 11, 2025

  • update oe-core nodejs version

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.95%. Comparing base (0c6c7bb) to head (acdab1e).

Files with missing lines Patch % Lines
app-shell-odd/electron-builder.config.js 0.00% 1 Missing ⚠️
app-shell/electron-builder.config.js 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #20117   +/-   ##
=======================================
  Coverage   25.95%   25.95%           
=======================================
  Files        3560     3560           
  Lines      297775   297775           
  Branches    42127    42127           
=======================================
  Hits        77277    77277           
  Misses     220479   220479           
  Partials       19       19           
Flag Coverage Δ
protocol-designer 19.18% <0.00%> (ø)
step-generation 5.46% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app-shell-odd/electron-builder.config.js 0.00% <0.00%> (ø)
app-shell/electron-builder.config.js 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants