Skip to content

Conversation

@SyntaxColoring
Copy link
Contributor

@SyntaxColoring SyntaxColoring commented Nov 24, 2025

Overview

In edge, PD is whitescreening with this console error:

13:11:30.678 index.js:3 Uncaught TypeError: Cannot destructure property '__extends' of 'import_tslib.default' as it is undefined.
    at index.js:3:5
(anonymous) @ index.js:3
13:13:18.067 (index):1 Unchecked runtime.lastError: Could not establish connection. Receiving end does not exist.

I do not understand any of this, but from git bisecting, the apparent cause is #20207's removal of include: ['tslib'] and/or dedupe: ['tslib'] from our Vite config. None of our other projects need this, so it's likely that there's some PD-specific weirdness going on here—possibly some misconfiguration somewhere else—but I haven't looked into it. This PR reverts the change as a quick fix to unblock development.

Test Plan and Hands on Testing

  • PD doesn't whitescreen now.

Review requests

Any better ideas?

Risk assessment

Low?

@SyntaxColoring SyntaxColoring requested review from a team, mjhuff and y3rsh and removed request for a team November 24, 2025 18:22
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.38%. Comparing base (f53562b) to head (d3fc0b1).
⚠️ Report is 1 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #20229   +/-   ##
=======================================
  Coverage   56.38%   56.38%           
=======================================
  Files        3623     3623           
  Lines      301011   301011           
  Branches    42246    42246           
=======================================
  Hits       169720   169720           
  Misses     131065   131065           
  Partials      226      226           
Flag Coverage Δ
protocol-designer 19.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SyntaxColoring SyntaxColoring merged commit 141e6cb into edge Nov 24, 2025
20 checks passed
@SyntaxColoring SyntaxColoring deleted the fix_pd_whitescreen branch November 24, 2025 18:53
ncdiehl11 added a commit that referenced this pull request Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants