Skip to content

fix for issues with char duplication #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2025
Merged

fix for issues with char duplication #309

merged 2 commits into from
Nov 13, 2025

Conversation

@Zemurin
Copy link
Member

@Zemurin Zemurin commented Nov 13, 2025

  • StringOfItem will no longer think it's working on quoted strings after encountering escaped quotes
  • Neither StringOfItem nor Parser rely on .eof() to indicate when they are done - this is inconsistent and prone to failure.

IhateTrains
IhateTrains reviewed Nov 13, 2025
View reviewed changes
@Zemurin Zemurin merged commit 587b2c4 into ParadoxGameConverters:master Nov 13, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IhateTrains IhateTrains IhateTrains approved these changes

@Idhrendur Idhrendur Awaiting requested review from Idhrendur Idhrendur is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zemurin @IhateTrains