Refactor DocumentSelection #1586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the reference to the owning document. This was only used for creating a Cairo.Context for building the selection path, but this doesn't actually need access to the document's active layer. Instead, a new utility method provides a context which can be used solely for building paths - Use `DocumentSelection.Bounds()` to get the selection bounds, rather than going through the Cairo.Path. This also makes the GetBounds() extension method unused, eliminating some references to the global PintaCore - Remove unused Path.Clone() extension method
cameronwhite
force-pushed
the
refactor/document-selection
branch
from
772db8e to
1ab9451
Compare
Contributor
|
Seems like, for some reason, we get a off-by-one selection after this commit: Screencast.from.03-07-2025.15.34.27.webm |
Member
Author
|
Thanks, I can reproduce that too - is it also happening for you with previous recent commits on the master branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tidies up some minor issues before making further changes in PR #1515
Remove the reference to the owning document. This was only used for creating a Cairo.Context for building the selection path, but this doesn't actually need access to the document's active layer. Instead, a new utility method provides a context which can be used solely for building paths
Use
DocumentSelection.Bounds()to get the selection bounds, rather than going through the Cairo.Path. This also makes the GetBounds() extension method unused, eliminating some references to the global PintaCoreRemove unused Path.Clone() extension method