fix patched tests

Author: timgl

posthog/storage/test/test_object_storage.py

@@ -40,7 +40,7 @@ def teardown_method(self, method) -> None:
         bucket = s3.Bucket(OBJECT_STORAGE_BUCKET)
         bucket.objects.filter(Prefix=TEST_BUCKET).delete()
 
-    @patch("posthog.storage.object_storage.client")
+    @patch("boto3.client")
     def test_does_not_create_client_if_storage_is_disabled(self, patched_s3_client) -> None:
         with self.settings(OBJECT_STORAGE_ENABLED=False):
             assert not health_check()

posthog/storage/test/test_session_recording_v2_object_storage.py

@@ -30,7 +30,7 @@ class TestSessionRecordingV2Storage(APIBaseTest):
     def teardown_method(self, method) -> None:
         pass
 
-    @patch("posthog.storage.session_recording_v2_object_storage.boto3_client")
+    @patch("boto3.client")
     def test_client_constructor_uses_correct_settings(self, patched_boto3_client) -> None:
         # Reset the global client to ensure we test client creation
         import posthog.storage.session_recording_v2_object_storage as storage_module
@@ -78,7 +78,7 @@ def test_client_constructor_uses_correct_settings(self, patched_boto3_client) ->
             ),
         ]
     )
-    @patch("posthog.storage.session_recording_v2_object_storage.boto3_client")
+    @patch("boto3.client")
     def test_does_not_create_client_if_required_settings_missing(self, settings_override, patched_s3_client) -> None:
         with self.settings(**settings_override):
             storage_client = client()
@@ -285,16 +285,16 @@ class TestAsyncSessionRecordingV2Storage(APIBaseTest):
     def teardown_method(self, method) -> None:
         pass
 
-    @patch("posthog.storage.session_recording_v2_object_storage.aioboto3")
-    async def test_client_constructor_uses_correct_settings(self, patched_aioboto3) -> None:
+    @patch("aioboto3.Session")
+    async def test_client_constructor_uses_correct_settings(self, patched_aioboto3_session) -> None:
         # Reset the global client to ensure we test client creation
         import posthog.storage.session_recording_v2_object_storage as storage_module
 
         client_mock = MagicMock(AsyncContextManager)
-        patched_aioboto3.Session.return_value.client = client_mock
+        patched_aioboto3_session.return_value.client = client_mock
 
         async with storage_module.async_client() as client:
-            assert patched_aioboto3.Session.call_count == 1
+            assert patched_aioboto3_session.call_count == 1
             assert client_mock.call_count == 1
 
             call_args = client_mock.call_args[0]
@@ -329,11 +329,13 @@ async def test_client_constructor_uses_correct_settings(self, patched_aioboto3)
             ),
         ]
     )
-    @patch("posthog.storage.session_recording_v2_object_storage.aioboto3")
-    async def test_throws_runtimeerror_if_required_settings_missing(self, settings_override, patched_aioboto3) -> None:
+    @patch("aioboto3.Session")
+    async def test_throws_runtimeerror_if_required_settings_missing(
+        self, settings_override, patched_aioboto3_session
+    ) -> None:
         with self.settings(**settings_override):
             client_mock = MagicMock(AsyncContextManager)
-            patched_aioboto3.Session.return_value.client = client_mock
+            patched_aioboto3_session.return_value.client = client_mock
 
             with self.assertRaises(RuntimeError) as _:
                 async with async_client() as _:

products/llm_analytics/backend/providers/test/test_gemini.py

@@ -35,7 +35,7 @@ def test_supported_models(self):
 
 class TestGeminiProvider(BaseTest):
     @override_settings(GEMINI_API_KEY="test-api-key")
-    @patch("products.llm_analytics.backend.providers.gemini.genai.Client")
+    @patch("posthoganalytics.ai.gemini.genai.Client")
     @patch("posthoganalytics.default_client")
     def test_provider_initialization(self, mock_posthog_client, mock_genai_client):
         mock_posthog_client.return_value = MagicMock()
@@ -57,7 +57,7 @@ def test_missing_posthog_client_raises_error(self):
             GeminiProvider("gemini-2.0-flash")
 
     @override_settings(GEMINI_API_KEY="test-api-key")
-    @patch("products.llm_analytics.backend.providers.gemini.genai.Client")
+    @patch("posthoganalytics.ai.gemini.genai.Client")
     @patch("posthoganalytics.default_client")
     def test_invalid_model_raises_error(self, mock_posthog_client, mock_genai_client):
         mock_posthog_client.return_value = MagicMock()
@@ -74,7 +74,7 @@ def setUp(self):
         self.messages = cast(list[MessageParam], [{"role": "user", "content": "Test message"}])
 
     @override_settings(GEMINI_API_KEY="test-api-key")
-    @patch("products.llm_analytics.backend.providers.gemini.genai.Client")
+    @patch("posthoganalytics.ai.gemini.genai.Client")
     @patch("posthoganalytics.default_client")
     def test_basic_text_streaming(self, mock_posthog, mock_genai):
         mock_posthog.return_value = self.mock_posthog_client
@@ -106,7 +106,7 @@ def mock_stream():
         assert json.loads(responses[1].replace("data: ", "").strip()) == {"type": "text", "text": "world!"}
 
     @override_settings(GEMINI_API_KEY="test-api-key")
-    @patch("products.llm_analytics.backend.providers.gemini.genai.Client")
+    @patch("posthoganalytics.ai.gemini.genai.Client")
     @patch("posthoganalytics.default_client")
     def test_streaming_with_none_parts(self, mock_posthog, mock_genai):
         mock_posthog.return_value = self.mock_posthog_client
@@ -136,7 +136,7 @@ def mock_stream():
         assert json.loads(responses[0].replace("data: ", "").strip()) == {"type": "text", "text": "Test text"}
 
     @override_settings(GEMINI_API_KEY="test-api-key")
-    @patch("products.llm_analytics.backend.providers.gemini.genai.Client")
+    @patch("posthoganalytics.ai.gemini.genai.Client")
     @patch("posthoganalytics.default_client")
     def test_streaming_with_empty_parts(self, mock_posthog, mock_genai):
         mock_posthog.return_value = self.mock_posthog_client
@@ -165,7 +165,7 @@ def mock_stream():
         assert len(responses) == 0
 
     @override_settings(GEMINI_API_KEY="test-api-key")
-    @patch("products.llm_analytics.backend.providers.gemini.genai.Client")
+    @patch("posthoganalytics.ai.gemini.genai.Client")
     @patch("posthoganalytics.default_client")
     def test_streaming_with_function_calls(self, mock_posthog, mock_genai):
         mock_posthog.return_value = self.mock_posthog_client
@@ -216,7 +216,7 @@ def mock_stream():
         assert json.loads(tool_response["function"]["arguments"]) == {"location": "San Francisco"}
 
     @override_settings(GEMINI_API_KEY="test-api-key")
-    @patch("products.llm_analytics.backend.providers.gemini.genai.Client")
+    @patch("posthoganalytics.ai.gemini.genai.Client")
     @patch("posthoganalytics.default_client")
     def test_streaming_with_text_in_parts(self, mock_posthog, mock_genai):
         mock_posthog.return_value = self.mock_posthog_client
@@ -252,7 +252,7 @@ def mock_stream():
         assert json.loads(responses[0].replace("data: ", "").strip()) == {"type": "text", "text": "Text from parts"}
 
     @override_settings(GEMINI_API_KEY="test-api-key")
-    @patch("products.llm_analytics.backend.providers.gemini.genai.Client")
+    @patch("posthoganalytics.ai.gemini.genai.Client")
     @patch("posthoganalytics.default_client")
     def test_streaming_with_mixed_parts(self, mock_posthog, mock_genai):
         mock_posthog.return_value = self.mock_posthog_client
@@ -305,7 +305,7 @@ def mock_stream():
         assert tool_response["function"]["name"] == "get_weather"
 
     @override_settings(GEMINI_API_KEY="test-api-key")
-    @patch("products.llm_analytics.backend.providers.gemini.genai.Client")
+    @patch("posthoganalytics.ai.gemini.genai.Client")
     @patch("posthoganalytics.default_client")
     def test_streaming_with_usage_metadata(self, mock_posthog, mock_genai):
         mock_posthog.return_value = self.mock_posthog_client
@@ -345,7 +345,7 @@ def setUp(self):
         self.messages = cast(list[MessageParam], [{"role": "user", "content": "Test message"}])
 
     @override_settings(GEMINI_API_KEY="test-api-key")
-    @patch("products.llm_analytics.backend.providers.gemini.genai.Client")
+    @patch("posthoganalytics.ai.gemini.genai.Client")
     @patch("posthoganalytics.default_client")
     def test_api_error_handling(self, mock_posthog, mock_genai):
         mock_posthog.return_value = self.mock_posthog_client
@@ -366,7 +366,7 @@ def test_api_error_handling(self, mock_posthog, mock_genai):
         assert error_response["error"] == "Gemini API error"
 
     @override_settings(GEMINI_API_KEY="test-api-key")
-    @patch("products.llm_analytics.backend.providers.gemini.genai.Client")
+    @patch("posthoganalytics.ai.gemini.genai.Client")
     @patch("posthoganalytics.default_client")
     def test_generic_exception_handling(self, mock_posthog, mock_genai):
         mock_posthog.return_value = self.mock_posthog_client
@@ -385,7 +385,7 @@ def test_generic_exception_handling(self, mock_posthog, mock_genai):
         assert error_response["error"] == "Unexpected error"
 
     @override_settings(GEMINI_API_KEY="test-api-key")
-    @patch("products.llm_analytics.backend.providers.gemini.genai.Client")
+    @patch("posthoganalytics.ai.gemini.genai.Client")
     @patch("posthoganalytics.default_client")
     def test_missing_candidates_attribute(self, mock_posthog, mock_genai):
         mock_posthog.return_value = self.mock_posthog_client
@@ -409,7 +409,7 @@ def mock_stream():
         assert json.loads(responses[0].replace("data: ", "").strip()) == {"type": "text", "text": "Text response"}
 
     @override_settings(GEMINI_API_KEY="test-api-key")
-    @patch("products.llm_analytics.backend.providers.gemini.genai.Client")
+    @patch("posthoganalytics.ai.gemini.genai.Client")
     @patch("posthoganalytics.default_client")
     def test_candidate_without_content(self, mock_posthog, mock_genai):
         mock_posthog.return_value = self.mock_posthog_client
@@ -438,7 +438,7 @@ def mock_stream():
 
 class TestGeminiIntegration(BaseTest):
     @override_settings(GEMINI_API_KEY="test-api-key")
-    @patch("products.llm_analytics.backend.providers.gemini.genai.Client")
+    @patch("posthoganalytics.ai.gemini.genai.Client")
     @patch("posthoganalytics.default_client")
     @patch("products.llm_analytics.backend.providers.gemini.uuid.uuid4")
     def test_trace_id_generation(self, mock_uuid, mock_posthog, mock_genai):
@@ -471,7 +471,7 @@ def mock_stream():
         assert call_kwargs["posthog_trace_id"] == test_uuid
 
     @override_settings(GEMINI_API_KEY="test-api-key")
-    @patch("products.llm_analytics.backend.providers.gemini.genai.Client")
+    @patch("posthoganalytics.ai.gemini.genai.Client")
     @patch("posthoganalytics.default_client")
     def test_properties_include_ai_product(self, mock_posthog, mock_genai):
         mock_posthog.return_value = MagicMock()
@@ -508,7 +508,7 @@ def mock_stream():
         ]
     )
     @override_settings(GEMINI_API_KEY="test-api-key")
-    @patch("products.llm_analytics.backend.providers.gemini.genai.Client")
+    @patch("posthoganalytics.ai.gemini.genai.Client")
     @patch("posthoganalytics.default_client")
     def test_temperature_and_max_tokens_handling(
         self, input_temp, input_max_tokens, expected_temp, expected_max_tokens, mock_posthog, mock_genai

products/workflows/backend/test/test_ses_provider.py

@@ -18,7 +18,7 @@ class TestSESProvider(TestCase):
     @classmethod
     def setUpClass(cls):
         # Patch boto3.client for all tests in this class
-        patcher = patch("products.workflows.backend.providers.ses.boto3.client")
+        patcher = patch("boto3.client")
         cls.boto3_client_patcher = patcher
         cls.mock_boto3_client = patcher.start()
 
@@ -84,7 +84,7 @@ def test_create_email_domain_success(self):
 
             provider.create_email_domain(TEST_DOMAIN, team_id=1)
 
-    @patch("products.workflows.backend.providers.ses.boto3.client")
+    @patch("boto3.client")
     def test_create_email_domain_invalid_domain(self, mock_boto_client):
         with override_settings(
             SES_ACCESS_KEY_ID="test_access_key", SES_SECRET_ACCESS_KEY="test_secret_key", SES_REGION="us-east-1"