feat(surveys): upgrade linked_insight from IntegerField to ForeignKey

Author: adboio

posthog/api/survey.py

@@ -833,7 +833,9 @@ def _create_or_update_targeting_flag(
 
 class SurveyViewSet(TeamAndOrgViewSetMixin, AccessControlViewSetMixin, viewsets.ModelViewSet):
     scope_object = "survey"
-    queryset = Survey.objects.select_related("linked_flag", "targeting_flag", "internal_targeting_flag").all()
+    queryset = Survey.objects.select_related(
+        "linked_flag", "linked_insight", "targeting_flag", "internal_targeting_flag"
+    ).all()
     filter_backends = [filters.SearchFilter]
     search_fields = ["name", "description"]
 

posthog/models/surveys/survey.py

@@ -71,7 +71,15 @@ class Meta:
         related_name="surveys_targeting_flag",
         related_query_name="survey_targeting_flag",
     )
-    linked_insight_id = models.IntegerField(null=True, blank=True)
+    linked_insight = models.ForeignKey(
+        "posthog.Insight",
+        null=True,
+        blank=True,
+        on_delete=models.SET_NULL,
+        related_name="surveys_linked_insight",
+        related_query_name="survey_linked_insight",
+        db_index=False,
+    )
     internal_targeting_flag = models.ForeignKey(
         "posthog.FeatureFlag",
         null=True,

products/surveys/backend/test_max_tools.py

@@ -381,7 +381,7 @@ async def test_create_survey_with_linked_insight(self, mock_create_survey):
         assert "successfully" in content
 
         # Verify survey was created with linked insight
-        survey = await sync_to_async(Survey.objects.get)(id=artifact["survey_id"])
+        survey = await sync_to_async(Survey.objects.select_related("linked_insight").get)(id=artifact["survey_id"])
         assert survey.name == "Funnel Survey"
         assert survey.linked_insight_id == insight.id