feat(ph-ai): agent modes #41284

skoob13 · 2025-11-11T16:51:01Z

Problem

We want to create more specialized agents within the single execution loop, so the context is preserved and the context window is not overwhelmed by it. This PR introduces three new modes under the feature flag phai-agent-modes: product analytics, SQL, and session replay.

Demo screenshot

Changes

Added new mode presets with manual registry–going to create an automated registry for the products directory later.
Created new tools that improved generation performance: create_insight, execute_sql, switch_mode, summarize_sessions.
Improved prompting around query execution, so we output prompt schemas.

How did you test this code?

Manual testing & unit tests

github-actions · 2025-11-11T17:26:56Z

Size Change: +1.18 kB (+0.03%)

Total Size: 3.42 MB

Filename	Size	Change
`frontend/dist/toolbar.js`	3.42 MB	+1.18 kB (+0.03%)

_{compressed-size-action}

wiz-7ad640923b · 2025-11-12T09:40:58Z

Wiz Scan Summary

Scanner	Findings
Vulnerabilities	-
Sensitive Data	1
Secrets	-
IaC Misconfigurations	-
SAST Findings	-

Total	1

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

posthog-bot · 2025-11-12T09:51:43Z

Visual regression: Storybook UI snapshots updated

Mode: UPDATE (triggered by human commit 5417f73)

Changes: 2 snapshots (2 modified, 0 added, 0 deleted)

What this means:

Snapshots have been automatically updated to match current rendering
Next CI run will switch to CHECK mode to verify stability
If snapshots change again, CHECK mode will fail (indicates flapping)

Next steps:

Review the changes to ensure they're intentional
Approve if changes match your expectations
If unexpected, investigate component rendering

Review snapshot changes →

greptile-apps

_{52 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}
_{React with 👍 or 👎 to share your feedback on this new summary format}

ee/hogai/tools/execute_sql/tool.py

kappa90

Was already checking this during the weekend, all super good, just left a few comments

ee/hogai/graph/agent_modes/nodes.py

ee/hogai/graph/agent_modes/presets/session_replay.py

kappa90 · 2025-11-17T10:50:19Z

ee/hogai/graph/schema_generator/nodes.py

            return start_message.content
        return ""

+    def _has_agent_modes_feature_flag(self) -> bool:


This is repeated three times, one in utils, one here and one somewhere in the modes files

kappa90 · 2025-11-17T10:58:56Z

ee/hogai/tools/create_insight.py

+from ee.hogai.utils.prompt import format_prompt_string
+from ee.hogai.utils.types.base import AssistantNodeName, AssistantState, NodePath
+
+INSIGHT_TOOL_PROMPT = """


Maybe worth moving this to its own file, since it's massive

tatoalo

Looks really nice, awaiting on evals! Thanks for putting this behind FF so we can actually test this nicely E2E 🙏🏻

tatoalo · 2025-11-17T11:42:58Z

ee/hogai/context/context.py

        return insert_messages_before_start(state.messages, context_messages, start_id=state.start_id)
+
+    def _get_mode_prompt(self, mode: AgentMode | None) -> str:
+        return format_prompt_string(CONTEXT_MODE_PROMPT, mode=mode.value if mode else AgentMode.PRODUCT_ANALYTICS.value)


nit: having product analytics as default does make sense, we could probably have a DEFAULT_AGENT_MODE constant to be more direct about this, not a biggie

kappa90 · 2025-11-17T12:54:40Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

greptile-apps

_{53 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}
_{React with 👍 or 👎 to share your feedback on this new summary format}

ee/hogai/graph/agent_modes/nodes.py

This reverts commit a796fd1.

This reverts commit c2bcce1.

This reverts commit 1a970f1.

skoob13 force-pushed the feat/agent-modes branch from c09562c to f0b3d9d Compare November 11, 2025 17:13

skoob13 changed the title ~~Feat/agent modes~~ feat(ph-ai): agent modes Nov 11, 2025

skoob13 force-pushed the feat/agent-modes branch 3 times, most recently from 6013386 to 338e8c9 Compare November 16, 2025 14:59

skoob13 requested review from a team, Twixes and kappa90 November 17, 2025 10:33

skoob13 marked this pull request as ready for review November 17, 2025 10:33

posthog-bot requested a review from a team November 17, 2025 10:34

greptile-apps bot reviewed Nov 17, 2025

View reviewed changes

ee/hogai/tools/execute_sql/tool.py Outdated Show resolved Hide resolved

skoob13 removed the request for review from a team November 17, 2025 10:36

kappa90 approved these changes Nov 17, 2025

View reviewed changes

skoob13 added the evals-ready Whether to run AI evals on this PR. label Nov 17, 2025

tatoalo approved these changes Nov 17, 2025

View reviewed changes

kappa90 mentioned this pull request Nov 17, 2025

refactor(ph-ai): conversation stream manager to agent executor #41613

Merged

skoob13 enabled auto-merge November 18, 2025 08:03

skoob13 removed the evals-ready Whether to run AI evals on this PR. label Nov 18, 2025

greptile-apps bot reviewed Nov 18, 2025

View reviewed changes

ee/hogai/graph/agent_modes/nodes.py Show resolved Hide resolved

This was referenced Nov 18, 2025

refactor(ph-ai): move chat agent specifics to dedicated classes #41697

Merged

refactor(ph-ai): clean up scaffolding #41713

Merged

skoob13 added this pull request to the merge queue Nov 19, 2025

skoob13 removed this pull request from the merge queue due to a manual request Nov 19, 2025

skoob13 added 3 commits November 19, 2025 13:28

Revert "revert: frontend modes"

10bf296

This reverts commit a796fd1.

Revert "revert: sql tool"

e4e6872

This reverts commit c2bcce1.

Revert "chore: remove modes and tools"

9dc1be5

This reverts commit 1a970f1.

skoob13 added 22 commits November 19, 2025 13:28

schema

6f7dbba

fix: regenerate schema

eb863e6

do not inject modes without ff

c6cf72e

fix: wip

3d2df52

fix: merge

ea085fe

fix: tests

0e05af2

feat: tests

2cfd4cd

small fixes

85e87ed

fix: tests

442b45c

fix: missing type

223f1dd

fix: do not copy tables

1471b3e

feat: optional context prompt

005446c

fix: remove thinking messages

e758cc2

feat: improve prompting around modes

95e0774

fix: do not display updates. it's just a single tool call now.

b61dfb1

feat: slightly improve prompting around modes

0ea25f9

feat: output query schema

97233ab

fix: tests

6185820

fix: edit insight tool

d951650

fix: remove QueryExecutorError

e2aad92

fix: review comments

929b9ef

fix: remove checks for the same mode

c982e8f

kappa90 force-pushed the feat/agent-modes branch from e7e4fcb to c982e8f Compare November 19, 2025 15:38

skoob13 enabled auto-merge November 19, 2025 16:02

skoob13 added this pull request to the merge queue Nov 19, 2025

Merged via the queue into master with commit 4c82d58 Nov 19, 2025
193 checks passed

skoob13 deleted the feat/agent-modes branch November 19, 2025 16:28

This was referenced Nov 20, 2025

feat(ph-ai): agent artifacts model #41830

Merged

feat(ph-ai): agent artifacts schema #41834

Merged

feat(ph-ai): agent modes #41284

feat(ph-ai): agent modes #41284

Uh oh!

Conversation

skoob13 commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Changes

How did you test this code?

Uh oh!

github-actions bot commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wiz-7ad640923b bot commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Wiz Scan Summary

Uh oh!

posthog-bot commented Nov 12, 2025

Visual regression: Storybook UI snapshots updated

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kappa90 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kappa90 Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

kappa90 Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

tatoalo left a comment

Choose a reason for hiding this comment

Uh oh!

tatoalo Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

kappa90 commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

skoob13 commented Nov 11, 2025 •

edited

Loading

github-actions bot commented Nov 11, 2025 •

edited

Loading

wiz-7ad640923b bot commented Nov 12, 2025 •

edited

Loading

kappa90 commented Nov 17, 2025 •

edited

Loading