-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Description
While I understand 1.43 is the current MW LTS, they have 1.44 marked as the current stable version, so I expect I'm not the only person that might be running into issues.
I'm currently running MW via the mediawiki Docker container on Dockerhub, customised via Dockerfile to install this extension using Composer. The wiki itself is fine, but when editing a page to add {{#subpages: }}, I'm greeted with the following type error (and the page isn't saved):
a257afa0b3e5f5a54fc06577] /index.php?title=Plurality&action=submit TypeError: SubPageList\Lister\SubPageList::renderForTitle(): Argument #1 ($title) must be of type Title, MediaWiki\Title\Title given, called in /var/www/html/extensions/SubPageList/src/Lister/SubPageList.php on line 59
Backtrace:
from /var/www/html/extensions/SubPageList/src/Lister/SubPageList.php(80)
#0 /var/www/html/extensions/SubPageList/src/Lister/SubPageList.php(59): SubPageList\Lister\SubPageList->renderForTitle(MediaWiki\Title\Title, array)
#1 /var/www/html/vendor/mediawiki/parser-hooks/src/FunctionRunner.php(48): SubPageList\Lister\SubPageList->handle(MediaWiki\Parser\Parser, ParamProcessor\ProcessingResult)
#2 /var/www/html/vendor/mediawiki/parser-hooks/src/HookRegistrant.php(45): ParserHooks\FunctionRunner->run(MediaWiki\Parser\Parser, array, MediaWiki\Parser\PPFrame_Hash)
#3 /var/www/html/includes/parser/Parser.php(3492): ParserHooks\HookRegistrant->ParserHooks\{closure}(MediaWiki\Parser\Parser, MediaWiki\Parser\PPFrame_Hash, array)
#4 /var/www/html/includes/parser/Parser.php(3148): MediaWiki\Parser\Parser->callParserFunction(MediaWiki\Parser\PPFrame_Hash, string, array, bool)
#5 /var/www/html/includes/parser/PPFrame_Hash.php(280): MediaWiki\Parser\Parser->braceSubstitution(array, MediaWiki\Parser\PPFrame_Hash)
#6 /var/www/html/includes/parser/Parser.php(2970): MediaWiki\Parser\PPFrame_Hash->expand(MediaWiki\Parser\PPNode_Hash_Tree, int)
#7 /var/www/html/includes/parser/Parser.php(1606): MediaWiki\Parser\Parser->replaceVariables(string)
#8 /var/www/html/includes/parser/Parser.php(705): MediaWiki\Parser\Parser->internalParse(string)
#9 /var/www/html/includes/content/WikitextContentHandler.php(380): MediaWiki\Parser\Parser->parse(string, MediaWiki\Title\Title, MediaWiki\Parser\ParserOptions, bool, bool, null)
#10 /var/www/html/includes/content/ContentHandler.php(1744): MediaWiki\Content\WikitextContentHandler->fillParserOutput(MediaWiki\Content\WikitextContent, MediaWiki\Content\Renderer\ContentParseParams, MediaWiki\Parser\ParserOutput)
#11 /var/www/html/includes/content/Renderer/ContentRenderer.php(75): MediaWiki\Content\ContentHandler->getParserOutput(MediaWiki\Content\WikitextContent, MediaWiki\Content\Renderer\ContentParseParams)
#12 /var/www/html/includes/Revision/RenderedRevision.php(261): MediaWiki\Content\Renderer\ContentRenderer->getParserOutput(MediaWiki\Content\WikitextContent, MediaWiki\Page\PageIdentityValue, MediaWiki\Revision\MutableRevisionRecord, MediaWiki\Parser\ParserOptions, array)
#13 /var/www/html/includes/Revision/RenderedRevision.php(233): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(MediaWiki\Content\WikitextContent, array)
#14 /var/www/html/includes/Revision/RevisionRenderer.php(236): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#15 /var/www/html/includes/Revision/RevisionRenderer.php(169): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, MediaWiki\Parser\ParserOptions, array)
#16 /var/www/html/includes/Revision/RenderedRevision.php(196): MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#17 /var/www/html/includes/Storage/DerivedPageDataUpdater.php(1414): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput(array)
#18 /var/www/html/extensions/AbuseFilter/includes/VariableGenerator/RunVariableGenerator.php(176): MediaWiki\Storage\DerivedPageDataUpdater->getParserOutputForMetaData()
#19 /var/www/html/extensions/AbuseFilter/includes/VariableGenerator/RunVariableGenerator.php(222): MediaWiki\Extension\AbuseFilter\VariableGenerator\RunVariableGenerator->newVariableHolderForEdit(MediaWiki\Page\WikiPage, string, MediaWiki\Content\WikitextContent, string, string, MediaWiki\Content\WikitextContent)
#20 /var/www/html/extensions/AbuseFilter/includes/Hooks/Handlers/FilteredActionsHandler.php(149): MediaWiki\Extension\AbuseFilter\VariableGenerator\RunVariableGenerator->getEditVars(MediaWiki\Content\WikitextContent, string, string, MediaWiki\Page\WikiPage)
#21 /var/www/html/extensions/AbuseFilter/includes/Hooks/Handlers/FilteredActionsHandler.php(105): MediaWiki\Extension\AbuseFilter\Hooks\Handlers\FilteredActionsHandler->filterEdit(MediaWiki\Context\DerivativeContext, MediaWiki\User\User, MediaWiki\Content\WikitextContent, string, string, MediaWiki\Status\Status)
#22 /var/www/html/includes/HookContainer/HookContainer.php(155): MediaWiki\Extension\AbuseFilter\Hooks\Handlers\FilteredActionsHandler->onEditFilterMergedContent(MediaWiki\Context\DerivativeContext, MediaWiki\Content\WikitextContent, MediaWiki\Status\Status, string, MediaWiki\User\User, bool)
#23 /var/www/html/includes/HookContainer/HookRunner.php(1532): MediaWiki\HookContainer\HookContainer->run(string, array)
#24 /var/www/html/includes/editpage/Constraint/EditFilterMergedContentHookConstraint.php(88): MediaWiki\HookContainer\HookRunner->onEditFilterMergedContent(MediaWiki\Context\DerivativeContext, MediaWiki\Content\WikitextContent, MediaWiki\Status\Status, string, MediaWiki\User\User, bool)
#25 /var/www/html/includes/editpage/Constraint/EditConstraintRunner.php(83): MediaWiki\EditPage\Constraint\EditFilterMergedContentHookConstraint->checkConstraint()
#26 /var/www/html/includes/editpage/EditPage.php(2475): MediaWiki\EditPage\Constraint\EditConstraintRunner->checkConstraints()
#27 /var/www/html/includes/editpage/EditPage.php(1842): MediaWiki\EditPage\EditPage->internalAttemptSave(null, bool, bool)
#28 /var/www/html/includes/editpage/EditPage.php(747): MediaWiki\EditPage\EditPage->attemptSave(null)
#29 /var/www/html/includes/actions/EditAction.php(68): MediaWiki\EditPage\EditPage->edit()
#30 /var/www/html/includes/actions/SubmitAction.php(40): MediaWiki\Actions\EditAction->show()
#31 /var/www/html/includes/actions/ActionEntryPoint.php(728): MediaWiki\Actions\SubmitAction->show()
#32 /var/www/html/includes/actions/ActionEntryPoint.php(505): MediaWiki\Actions\ActionEntryPoint->performAction(MediaWiki\Page\Article, MediaWiki\Title\Title)
#33 /var/www/html/includes/actions/ActionEntryPoint.php(143): MediaWiki\Actions\ActionEntryPoint->performRequest()
#34 /var/www/html/includes/MediaWikiEntryPoint.php(202): MediaWiki\Actions\ActionEntryPoint->execute()
#35 /var/www/html/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#36 {main}
I'm assuming this in itself is a relatively simple type change, but I'm not a PHP dev, so I don't want to presume too much.
Either way, are there any plans to support MW 1.44 any time soon? Thanks for the great extension and your time!
JeroenDeDauw
Metadata
Metadata
Assignees
Labels
No labels