Merge pull request #292 from strega-nil-ms/fix-buffer-overrun-test

jinguoli · web-flow · commit 09a8a3c613c2 · 2022-10-17T10:40:17.000+08:00
Fix buffer overrun in udp_server_test.cc
diff --git a/test/udp_server_test.cc b/test/udp_server_test.cc
@@ -11,7 +11,7 @@ static void OnMessage(evpp::udp::Server* udpsrv, evpp::EventLoop* loop, const ev
     g_count++;
     evpp::udp::SendMessage(msg);
     usleep(100);
-    if (memcmp(msg->data(), "stop", msg->size()) == 0) {
+    if (msg->size() == 4 && memcmp(msg->data(), "stop", 4) == 0) {
         g_exit = true;
     }
 }
@@ -88,4 +88,4 @@ TEST_UNIT(testUDPServerGraceStop) {
     udpsrv->Stop(true);
     H_TEST_ASSERT(udpsrv->IsStopped());
     delete udpsrv;
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ static void OnMessage(evpp::udp::Server* udpsrv, evpp::EventLoop* loop, const ev`
`11`	`11`	`g_count++;`
`12`	`12`	`evpp::udp::SendMessage(msg);`
`13`	`13`	`usleep(100);`
`14`		`- if (memcmp(msg->data(), "stop", msg->size()) == 0) {`
	`14`	`+ if (msg->size() == 4 && memcmp(msg->data(), "stop", 4) == 0) {`
`15`	`15`	`g_exit = true;`
`16`	`16`	`}`
`17`	`17`	`}`
`@@ -88,4 +88,4 @@ TEST_UNIT(testUDPServerGraceStop) {`
`88`	`88`	`udpsrv->Stop(true);`
`89`	`89`	`H_TEST_ASSERT(udpsrv->IsStopped());`
`90`	`90`	`delete udpsrv;`
`91`		`-}`
	`91`	`+}`