Skip to content

Bug or intended: overlapping_markups isn't used by injector #17

@UrsineRaven

Description

@UrsineRaven

I was going through the code and I noticed that cli-real-favicon is not passing the overlapping_markups from the api result to rfg-api. So, it appears that rfg-api always ends up using its defaultRemove list which makes more generic removals rather than targeting the exact tags that need to be removed. This may be intended, but I wanted to point it out just in case.

Also, it would be nice to actually use overlapping_markups, because then we can add additional tags if we want to replace our own tags (e.g. title).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions