Skip to content

Commit ce4862b

Browse files
Resolve comments
1 parent 517375c commit ce4862b

File tree

5 files changed

+6
-5
lines changed

5 files changed

+6
-5
lines changed

Recap/Services/LLM/Core/LLMTaskManageable.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ extension LLMTaskManageable {
2020
return try await withTaskCancellationHandler {
2121
try await operation()
2222
} onCancel: {
23-
Task.detached { [weak self] in
23+
Task { [weak self] in
2424
await self?.cancelCurrentTask()
2525
}
2626
}

Recap/Services/LLM/Providers/Ollama/OllamaProvider.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ final class OllamaProvider: LLMProviderType, LLMTaskManageable {
3333
}
3434

3535
deinit {
36-
Task.detached { [weak self] in
36+
Task { [weak self] in
3737
await self?.cancelCurrentTask()
3838
}
3939
}

Recap/Services/LLM/Providers/OpenRouter/OpenRouterProvider.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ final class OpenRouterProvider: LLMProviderType, LLMTaskManageable {
3333
}
3434

3535
deinit {
36-
Task.detached { [weak self] in
36+
Task { [weak self] in
3737
await self?.cancelCurrentTask()
3838
}
3939
}

Recap/Services/Utilities/Warnings/WarningManagerType.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import Combine
44
import Mockable
55
#endif
66

7+
@MainActor
78
#if MOCKING
89
@Mockable
910
#endif
@@ -54,4 +55,4 @@ enum WarningSeverity {
5455
return "FF3B30"
5556
}
5657
}
57-
}
58+
}

Recap/UseCases/Home/ViewModel/RecapViewModel.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ final class RecapViewModel: ObservableObject {
171171
}
172172

173173
deinit {
174-
Task.detached { [weak self] in
174+
Task { [weak self] in
175175
await self?.stopTimers()
176176
}
177177
}

0 commit comments

Comments
 (0)