Skip to content

Commit 5d61d16

Browse files
fix example
1 parent 920f973 commit 5d61d16

File tree

3 files changed

+34
-2
lines changed

3 files changed

+34
-2
lines changed

examples/fail_example.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ def __init__(
4040

4141
def transform(self, documents: List[Document]) -> List[Document]:
4242
try:
43-
text = [document[self.text_field] for document in documents]
43+
raise ValueError
44+
4445
except:
4546
# pass
4647
raise UserFacingError(

tests/conftest.py

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,21 @@ def partial_dataset(test_client: Client) -> Dataset:
7878
test_client.delete_dataset(dataset_id)
7979

8080

81+
@pytest.fixture(scope="class")
82+
def simple_partial_dataset(test_client: Client) -> Dataset:
83+
salt = "".join(random.choices(string.ascii_lowercase, k=10))
84+
dataset_id = f"_sample_dataset_{salt}"
85+
dataset = test_client.Dataset(dataset_id, expire=True)
86+
documents = mock_documents(1000)
87+
fields = ["sample_1_label"]
88+
for document in documents:
89+
for field in random.sample(fields, k=random.randint(1, 3)):
90+
document.pop(field)
91+
dataset.insert_documents(documents)
92+
yield dataset
93+
test_client.delete_dataset(dataset_id)
94+
95+
8196
@pytest.fixture(scope="class")
8297
def partial_dataset_with_outputs(test_client: Client) -> Dataset:
8398
salt = "".join(random.choices(string.ascii_lowercase, k=10))
@@ -297,7 +312,7 @@ def test_user_facing_error_workflow_token(test_client: Client) -> str:
297312
job_id=job_id,
298313
dataset_id=dataset_id,
299314
authorizationToken=test_client.credentials.token,
300-
text_field="sample_1_description_not_in_dataset",
315+
text_field="sample_1_description",
301316
)
302317
config_string = json.dumps(config)
303318
config_bytes = config_string.encode()

tests/core/test_engine/test_stable_engine.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,3 +62,19 @@ def test_stable_engine_filters2(
6262
assert prev_health[input_field]["exists"] == post_health[output_field]["exists"]
6363

6464
assert engine.success_ratio == 1
65+
66+
def test_stable_engine_filters3(
67+
self, simple_partial_dataset: Dataset, test_partial_operator: Type[AbstractOperator]
68+
):
69+
prev_health = simple_partial_dataset.health()
70+
operator = test_partial_operator(["sample_1_label"])
71+
72+
engine = StableEngine(simple_partial_dataset, operator, select_fields=["sample_1_label"], refresh=False)
73+
workflow = Workflow(name=_random_id(), engine=engine, job_id=_random_id())
74+
workflow.run()
75+
76+
post_health = simple_partial_dataset.health()
77+
for input_field, output_field in zip(operator.input_fields, operator.output_fields):
78+
assert prev_health[input_field]["exists"] == post_health[output_field]["exists"]
79+
80+
assert engine.success_ratio == 1

0 commit comments

Comments
 (0)