Skip to content

Commit ff234f1

Browse files
authored
Merge pull request #336 from STAPLE-verse/fix-0710
Fix 0710
2 parents 7d29416 + ef7a6fd commit ff234f1

File tree

6 files changed

+19
-6
lines changed

6 files changed

+19
-6
lines changed

src/core/components/Modal.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,13 @@ const Modal = ({ children, open, size = "max-w-lg" }: Props) => {
1515
renderBackdrop={(props) => (
1616
<div {...props} className="fixed inset-0 bg-black opacity-50 z-[1040]" />
1717
)}
18-
className="fixed inset-0 flex items-center justify-center z-[1050]"
18+
className="fixed inset-0 flex items-center justify-center z-[1050] overflow-y-auto"
1919
>
2020
<div
21-
className={cn("flex justify-center bg-base-100 p-6 rounded-lg shadow-lg relative", size)}
21+
className={cn(
22+
"flex justify-center bg-base-100 p-6 rounded-lg shadow-lg relative max-w-lg w-full md:max-w-2xl max-h-[90vh] overflow-y-auto",
23+
size
24+
)}
2225
>
2326
<div className="w-full">{children}</div>
2427
</div>

src/pages/projects/[projectId]/tasks/[taskId]/tasklog.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ const AssignmentsContent = () => {
2525
const processedIndividualAssignments = processIndividualTaskLogs(individualProjectMembers)
2626
const processedTeamAssignments = processTeamTaskLogs(teamProjectMembers)
2727

28+
console.log(processedTeamAssignments)
29+
2830
// Get columns definitions for tables
2931
const individualColumns = task.formVersionId ? taskLogTableColumnsSchema : taskLogTableColumns
3032
const teamColumns = task.formVersionId ? teamTaskLogTableColumnsSchema : teamTaskLogTableColumns

src/tasklogs/components/ShowTeamModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export const ShowTeamModal = ({ projectMember }) => {
2727
data-testid="open-modal"
2828
onClick={() => handleToggle()}
2929
>
30-
<span>{`${projectMember.name}`}</span>
30+
<span>{`${projectMember.projectMember.name}`}</span>
3131
</button>
3232
<Tooltip
3333
id="showTeamModalTooltip"

src/tasklogs/components/TeamTaskLogTable.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,14 @@ const columnHelper = createColumnHelper<ProcessedTeamTaskLog>()
1111
// ColumnDefs
1212
export const teamTaskLogTableColumns: ColumnDef<ProcessedTeamTaskLog>[] = [
1313
columnHelper.accessor("projectMember", {
14-
cell: (info) => <div>{<ShowTeamModal projectMember={info.getValue()}></ShowTeamModal>}</div>,
14+
cell: (info) => {
15+
const rowData = info.row.original // Access the entire row data
16+
return (
17+
<div>
18+
<ShowTeamModal projectMember={rowData}></ShowTeamModal>
19+
</div>
20+
)
21+
},
1522
header: "Team Name",
1623
}),
1724
columnHelper.accessor("lastUpdate", {

src/tasklogs/utils/processTaskLogs.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export function processTeamTaskLogs(
5757

5858
const latestLog = filterLatestTaskLog(projectMember.taskLogAssignedTo)
5959
return {
60-
projectMember: getProjectMemberName(projectMember),
60+
projectMember: projectMember,
6161
lastUpdate: latestLog
6262
? latestLog.createdAt.toLocaleDateString(undefined, {
6363
year: "numeric",
@@ -75,6 +75,7 @@ export function processTeamTaskLogs(
7575
: "Not Completed"
7676
: "Unknown",
7777
taskLog: latestLog,
78+
users: projectMember.users,
7879
}
7980
})
8081
}

test/ShowTeamModal.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
import { expect, vi, test } from "vitest"
66
import { render, screen, fireEvent } from "test/utils"
7-
import { ShowTeamModal } from "src/assignments/components/ShowTeamModal"
7+
import { ShowTeamModal } from "src/tasklogs/components/ShowTeamModal"
88

99
test("renders show team modal", async () => {
1010
const curentTeam = {

0 commit comments

Comments
 (0)