Released version 1.3.6

Author: SimonSimCity

CHANGELOG.md

@@ -1,9 +1,21 @@
 ## Changes
 
-### 1.3.3
+### 1.3.6
+
+  * Fixed bug [#77](https://github.com/SimonSimCity/Xamarin-CrossDownloadManager/issues/77): [Android] Download are cancelled with no reason
+
+### 1.3.5
+
+  * *changes in documentation*
+
+### 1.3.4
 
   * Add possibility to prevent files from showing up in download manager
 
+### 1.3.3
+
+  * *no changes*
+
 ### 1.3.2
 
   * Fixed bug [#69](https://github.com/SimonSimCity/Xamarin-CrossDownloadManager/issues/69): Using PathNameForDownloadedFile: Android suffixes filename by '-1' if file already exists

DownloadManager/Plugin.DownloadManager.Android/DownloadManagerImplementation.cs

@@ -127,19 +127,24 @@ void StartDownloadWatcher ()
             // Create a runnable, restarting itself to update every file in the queue
             _downloadWatcherHandlerRunnable = new Java.Lang.Runnable (() => {
                 var downloads = Queue.Cast<DownloadFileImplementation>().ToList();
-                LoopOnDownloads (cursor => {
-                    int id = cursor.GetInt(cursor.GetColumnIndex(Android.App.DownloadManager.ColumnId));
-                    var downloadFile = downloads.FirstOrDefault(f => f.Id == id);
 
-                    if (downloadFile != null) {
-                        downloads.Remove(downloadFile);
-                        UpdateFileProperties(cursor, downloadFile);
-                    }
-                });
-
-                // All downloads still in this list are not listed in the native donload-manager of Android. Mark them as canceled.
                 foreach (var file in downloads) {
-                    Abort(file);
+                    var query = new Android.App.DownloadManager.Query();
+                    query.SetFilterById(file.Id);
+
+                    try {
+                        using (var cursor = _downloadManager.InvokeQuery(query)) {
+                            if (cursor != null && cursor.MoveToNext()) {
+                                UpdateFileProperties(cursor, file);
+                            } else {
+                                // This file is not listed in the native download manager anymore. Let's mark it as canceled.
+                                Abort(file);
+                            }
+                            cursor?.Close();
+                        }
+                    } catch (Android.Database.Sqlite.SQLiteException) {
+                        // I lately got an exception that the database was unaccessible ...
+                    }
                 }
 
                 _downloadWatcherHandler.PostDelayed (_downloadWatcherHandlerRunnable, 1000);

README.md

@@ -2,7 +2,7 @@
 
 The CrossDownloadManager is a plugin that helps you downloading files in the background.
 
-### Build Status: 
+### Build Status:
 ![GitHub tag](https://img.shields.io/github/tag/SimonSimCity/xamarin-crossdownloadmanager.svg)
 [![NuGet](https://img.shields.io/nuget/v/Xam.Plugins.DownloadManager.svg?label=NuGet)](https://www.nuget.org/packages/Xam.Plugins.DownloadManager/)
 
@@ -23,26 +23,26 @@ Add the nuget package to your cross-platform project and to every platform speci
 #### iOS
 
 _AppDelegate.cs_
-```
-    /**
-     * Save the completion-handler we get when the app opens from the background.
-     * This method informs iOS that the app has finished all internal processing and can sleep again.
-     */
-    public override void HandleEventsForBackgroundUrl(UIApplication application, string sessionIdentifier, Action completionHandler)
-    {
-        CrossDownloadManager.BackgroundSessionCompletionHandler = completionHandler;
-    }
+```csharp
+/**
+ * Save the completion-handler we get when the app opens from the background.
+ * This method informs iOS that the app has finished all internal processing and can sleep again.
+ */
+public override void HandleEventsForBackgroundUrl(UIApplication application, string sessionIdentifier, Action completionHandler)
+{
+    CrossDownloadManager.BackgroundSessionCompletionHandler = completionHandler;
+}
 ```
 
 As of iOS 9, your URL must be secured or you have to add the domain to the list of exceptions. See [https://developer.apple.com/library/ios/releasenotes/General/WhatsNewIniOS/Articles/iOS9.html#//apple_ref/doc/uid/TP40016198-SW14](https://developer.apple.com/library/ios/releasenotes/General/WhatsNewIniOS/Articles/iOS9.html#//apple_ref/doc/uid/TP40016198-SW14)
 
 ### Start downloading
 
 You can now start a download by adding the following code:
-```
-    var downloadManager = CrossDownloadManager.Current;
-    var file = downloadManager.CreateDownloadFile(url);
-    downloadManager.Start(file);
+```csharp
+var downloadManager = CrossDownloadManager.Current;
+var file = downloadManager.CreateDownloadFile(url);
+downloadManager.Start(file);
 ```
 
 This will add the file to a native library, which starts the download of that file. You can watch the properties of the `IDownloadFile` instance and execute some code if e.g. the status changes to `COMPLETED`, you can also watch the `IDownloadManager.Queue` and execute some code if the list of files, that will be downloaded or are currently downloading changes.
@@ -60,28 +60,28 @@ When you choose not to provide your own path before starting the download, the d
 #### Recommended Option - Custom Location
 
 Usually, you would expect to set the path to the `IDownloadFile` instance, you get when calling `downloadManager.CreateDownloadFile(url)`. But, as this download manager even continues downloading when the app crashed, you have to be able to reconstruct the path in every stage of the app. The correct way is to register a method as early as possible, that, in every circumstance, can reconstruct the path that the file should be saved. This method could look like following:
-```
-    CrossDownloadManager.Current.PathNameForDownloadedFile = new System.Func<IDownloadFile, string> (file => {
+```csharp
+CrossDownloadManager.Current.PathNameForDownloadedFile = new System.Func<IDownloadFile, string> (file => {
 #if __IOS__
-            string fileName = (new NSUrl(file.Url, false)).LastPathComponent;
-            return Path.Combine(Environment.GetFolderPath (Environment.SpecialFolder.MyDocuments), fileName);
+    string fileName = (new NSUrl(file.Url, false)).LastPathComponent;
+    return Path.Combine(Environment.GetFolderPath (Environment.SpecialFolder.MyDocuments), fileName);
 #elif __ANDROID__
-            string fileName = Android.Net.Uri.Parse(file.Url).Path.Split('/').Last();
-            return Path.Combine (ApplicationContext.GetExternalFilesDir (Android.OS.Environment.DirectoryDownloads).AbsolutePath, fileName);
+    string fileName = Android.Net.Uri.Parse(file.Url).Path.Split('/').Last();
+    return Path.Combine (ApplicationContext.GetExternalFilesDir (Android.OS.Environment.DirectoryDownloads).AbsolutePath, fileName);
 #else
-            string fileName = '';
-            return Path.Combine(Environment.GetFolderPath (Environment.SpecialFolder.MyDocuments), fileName);
+    string fileName = '';
+    return Path.Combine(Environment.GetFolderPath (Environment.SpecialFolder.MyDocuments), fileName);
 #endif
-        });
+});
 ```
 
 **Warning:** Please check if the files exist. The CrossDownloadManager will overwrite the file if it already exists.
 
 ##### Additional for Andriod
 
 On Android, the destination location must be a located outside of your Apps internal directory (see [#10](https://github.com/SimonSimCity/Xamarin-CrossDownloadManager/issues/10) for details). To allow your app to write to that location, you either have to add the permission `WRITE_EXTERNAL_STORAGE` to the mainfest.xml file to require it when installing the app
-```
-    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
+```xml
+<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
 ```
 
 or to request it at runtime (See [#20](https://github.com/SimonSimCity/Xamarin-CrossDownloadManager/issues/20)).
@@ -92,18 +92,20 @@ All finished downloads are registered in a native `Downloads` application. If yo
 
 Just register the instance in `CrossDownloadManager.Current` in the library. Here's an example how to do it on MvvmCross:
 
-    Mvx.RegisterSingleton<IDownloadManager>(() => CrossDownloadManager.Current);
+```csharp
+Mvx.RegisterSingleton<IDownloadManager>(() => CrossDownloadManager.Current);
+```
 
 ### Can I have a look at a sample implementation?
 
 I've created a quite basic implementation for UWP, iOS and Android which you can find [here](https://github.com/SimonSimCity/Xamarin-CrossDownloadManager/tree/develop/Sample). Feel free to fork this repository and play around with it. It's right within the `Sample` folder.
 
 ### Why do the files show up in the native Android Download Manager?
 
-That is the default behavior when downloading files using the Android DownladManager API. If you don't want this to happen you can change the property IsVisibleInDownloadsUi of the DownloadManagerImplementation
+This is the default of the native download manager on Android. You can change this behavior by setting the property `IsVisibleInDownloadsUi` of the Android implementation of the download manager to `false`. Here's an example which you can copy into your Android application:
 
-```
-	(CrossDownloadManager.Current as DownloadManagerImplementation).IsVisibleInDownloadsUi = false;
+```csharp
+(CrossDownloadManager.Current as DownloadManagerImplementation).IsVisibleInDownloadsUi = false;
 ```
 
 ### Contribute / Bugs / Features