SONARFLEX-173 Update rule metadata with clean code taxonomy attributes

Author: saberduck

flex-checks/src/main/resources/org/sonar/l10n/flex/rules/flex/ActionScript2.json

@@ -1,6 +1,12 @@
 {
   "title": "Statements, operators and keywords specific to ActionScript 2 should not be used",
   "type": "CODE_SMELL",
+  "code": {
+    "impacts": {
+      "MAINTAINABILITY": "MEDIUM"
+    },
+    "attribute": "CONVENTIONAL"
+  },
   "status": "ready",
   "remediation": {
     "func": "Constant\/Issue",

flex-checks/src/main/resources/org/sonar/l10n/flex/rules/flex/CommentRegularExpression.json

@@ -1,6 +1,12 @@
 {
   "title": "Track comments matching a regular expression",
   "type": "CODE_SMELL",
+  "code": {
+    "impacts": {
+      "MAINTAINABILITY": "MEDIUM"
+    },
+    "attribute": "CONVENTIONAL"
+  },
   "status": "ready",
   "remediation": {
     "func": "Constant\/Issue",

flex-checks/src/main/resources/org/sonar/l10n/flex/rules/flex/CommentedCode.json

@@ -1,6 +1,12 @@
 {
   "title": "Sections of code should not be commented out",
   "type": "CODE_SMELL",
+  "code": {
+    "impacts": {
+      "MAINTAINABILITY": "MEDIUM"
+    },
+    "attribute": "CLEAR"
+  },
   "status": "ready",
   "remediation": {
     "func": "Constant\/Issue",

flex-checks/src/main/resources/org/sonar/l10n/flex/rules/flex/FunctionComplexity.json

@@ -1,6 +1,12 @@
 {
   "title": "Cyclomatic Complexity of functions should not be too high",
   "type": "CODE_SMELL",
+  "code": {
+    "impacts": {
+      "MAINTAINABILITY": "HIGH"
+    },
+    "attribute": "FOCUSED"
+  },
   "status": "ready",
   "remediation": {
     "func": "Linear with offset",

flex-checks/src/main/resources/org/sonar/l10n/flex/rules/flex/FunctionSinglePointOfExit.json

@@ -1,6 +1,12 @@
 {
   "title": "A function should have a single point of exit at the end of the function",
   "type": "CODE_SMELL",
+  "code": {
+    "impacts": {
+      "MAINTAINABILITY": "LOW"
+    },
+    "attribute": "CONVENTIONAL"
+  },
   "status": "ready",
   "remediation": {
     "func": "Constant\/Issue",

flex-checks/src/main/resources/org/sonar/l10n/flex/rules/flex/LineLength.json

@@ -1,6 +1,12 @@
 {
   "title": "Lines should not be too long",
   "type": "CODE_SMELL",
+  "code": {
+    "impacts": {
+      "MAINTAINABILITY": "MEDIUM"
+    },
+    "attribute": "FORMATTED"
+  },
   "status": "ready",
   "remediation": {
     "func": "Constant\/Issue",

flex-checks/src/main/resources/org/sonar/l10n/flex/rules/flex/NonEmptyCaseWithoutBreak.json

@@ -1,6 +1,12 @@
 {
   "title": "Switch cases should end with an unconditional \"break\" statement",
   "type": "CODE_SMELL",
+  "code": {
+    "impacts": {
+      "MAINTAINABILITY": "HIGH"
+    },
+    "attribute": "CLEAR"
+  },
   "status": "ready",
   "remediation": {
     "func": "Constant\/Issue",

flex-checks/src/main/resources/org/sonar/l10n/flex/rules/flex/OneStatementPerLine.html

@@ -1,12 +1,11 @@
 <h2>Why is this an issue?</h2>
-<p>For better readability, do not put more than one statement on a single line.</p>
-<h3>Noncompliant code example</h3>
+<p>Putting multiple statements on a single line lowers the code readability and makes debugging the code more complex.</p>
 <pre>
-if(someCondition) doSomething();
+if (someCondition) doSomething(); // Noncompliant
 </pre>
-<h3>Compliant solution</h3>
+<p>Write one statement per line to improve readability.</p>
 <pre>
-if(someCondition) {
+if (someCondition) {
   doSomething();
 }
 </pre>

flex-checks/src/main/resources/org/sonar/l10n/flex/rules/flex/OneStatementPerLine.json

@@ -1,6 +1,12 @@
 {
   "title": "Statements should be on separate lines",
   "type": "CODE_SMELL",
+  "code": {
+    "impacts": {
+      "MAINTAINABILITY": "MEDIUM"
+    },
+    "attribute": "FORMATTED"
+  },
   "status": "ready",
   "remediation": {
     "func": "Constant\/Issue",

flex-checks/src/main/resources/org/sonar/l10n/flex/rules/flex/S100.json

@@ -1,6 +1,12 @@
 {
   "title": "Function names should comply with a naming convention",
   "type": "CODE_SMELL",
+  "code": {
+    "impacts": {
+      "MAINTAINABILITY": "LOW"
+    },
+    "attribute": "IDENTIFIABLE"
+  },
   "status": "ready",
   "remediation": {
     "func": "Constant\/Issue",