Skip to content

Commit 59c0140

Browse files
Improve coverage
1 parent d8b09c8 commit 59c0140

File tree

2 files changed

+17
-1
lines changed

2 files changed

+17
-1
lines changed

java-checks-test-sources/default/src/test/java/checks/tests/SpringBootEmptyMethodsCheckSample.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
class SpringBootSanityTest {
88
// Compliant, first time we encounter a spring sanity test
99
@Test
10-
void contextLoads() {}
10+
void contextLoads() {
11+
}
1112

1213
// Noncompliant@+2
1314
@Test

java-frontend/src/test/java/org/sonar/java/model/JavaVersionImplTest.java

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,16 @@
1616
*/
1717
package org.sonar.java.model;
1818

19+
import java.util.Optional;
1920
import org.junit.jupiter.api.Test;
2021
import org.junit.jupiter.params.ParameterizedTest;
2122
import org.junit.jupiter.params.provider.ValueSource;
23+
import org.sonar.api.config.Configuration;
2224
import org.sonar.plugins.java.api.JavaVersion;
2325

2426
import static org.assertj.core.api.Assertions.assertThat;
27+
import static org.mockito.Mockito.doReturn;
28+
import static org.mockito.Mockito.mock;
2529

2630
class JavaVersionImplTest {
2731

@@ -182,5 +186,16 @@ void test_fromMap() {
182186
assertThat(version.asInt()).isEqualTo(-1);
183187
assertThat(version.arePreviewFeaturesEnabled()).isFalse();
184188
}
189+
190+
@Test
191+
void test_preview_features_without_max_version_from_config(){
192+
var config = mock(Configuration.class);
193+
doReturn(Optional.of("17")).when(config).get(JavaVersion.SOURCE_VERSION);
194+
doReturn(Optional.of("true")).when(config).get(JavaVersion.ENABLE_PREVIEW);
195+
var javaVersion = JavaVersionImpl.readFromConfiguration(config);
196+
assertThat(javaVersion.asInt()).isEqualTo(17);
197+
// Preview features should be disabled because 17 is not the max supported version
198+
assertThat(javaVersion.arePreviewFeaturesEnabled()).isFalse();
199+
}
185200

186201
}

0 commit comments

Comments
 (0)