fix: preserve RemoteTemporaryFile type when working with remote storage (#4290)

* fix: preserve `RemoteTemporaryFile` type when working with remote storage

- Added optional parameter to `RemoteTemporaryFile::sync()` allowing directory creation without content copying
- Modified `Writer` to use `RemoteTemporaryFile::sync(false)` instead of creating a new `LocalTemporaryFile`
- Prevents type change from `RemoteTemporaryFile` to `LocalTemporaryFile` while ensuring local directory structure exists for writing

* chore: Remove unused import

Author: hschimpf

src/Files/RemoteTemporaryFile.php

@@ -93,14 +93,14 @@ public function delete(): bool
     /**
      * @return TemporaryFile
      */
-    public function sync(): TemporaryFile
+    public function sync(bool $copy = true): TemporaryFile
     {
         if (!$this->localTemporaryFile->exists()) {
             $this->localTemporaryFile = resolve(TemporaryFileFactory::class)
                 ->makeLocal(Arr::last(explode('/', $this->filename)));
         }
 
-        $this->disk()->copy(
+        $copy && $this->disk()->copy(
             $this,
             $this->localTemporaryFile->getLocalPath()
         );

src/Writer.php

@@ -2,7 +2,6 @@
 
 namespace Maatwebsite\Excel;
 
-use Illuminate\Support\Arr;
 use Maatwebsite\Excel\Concerns\WithBackgroundColor;
 use Maatwebsite\Excel\Concerns\WithCustomValueBinder;
 use Maatwebsite\Excel\Concerns\WithDefaultStyles;
@@ -177,8 +176,9 @@ public function write($export, TemporaryFile $temporaryFile, string $writerType)
         );
 
         if ($temporaryFile instanceof RemoteTemporaryFile && !$temporaryFile->existsLocally() && !$this->isRunningServerless()) {
-            $temporaryFile = resolve(TemporaryFileFactory::class)
-                ->makeLocal(Arr::last(explode('/', $temporaryFile->getLocalPath())));
+            // just ensure that local copy exists (it creates the directory structure),
+            // no need to copy remote content since it will be overwritten below
+            $temporaryFile->sync(false);
         }
 
         $writer->save(