[Rendering] Fix for Render Passes not updating render data in time;

[Rendering] Fixes to depth and stencil handling;

Author: LittleCodingFox

Engine/Staple.Core/Rendering/RenderSystem/Backend/Impls/SDLGPU/Commands/SDLGPUBeginRenderPassCommand.cs

@@ -96,6 +96,12 @@ public void Update(IRendererBackend rendererBackend)
             },
             store_op = SDL.SDL_GPUStoreOp.SDL_GPU_STOREOP_STORE,
             texture = depthTextureResource.texture,
+            stencil_load_op = clearMode switch
+            {
+                CameraClearMode.None => SDL.SDL_GPULoadOp.SDL_GPU_LOADOP_LOAD,
+                _ => SDL.SDL_GPULoadOp.SDL_GPU_LOADOP_CLEAR,
+            },
+            stencil_store_op = SDL.SDL_GPUStoreOp.SDL_GPU_STOREOP_STORE,
         };
 
         backend.renderPass = SDL.SDL_BeginGPURenderPass(backend.commandBuffer, [colorTarget], 1, in depthTarget);

Engine/Staple.Core/Rendering/RenderSystem/Backend/Impls/SDLGPU/Commands/SDLGPURenderCommand.cs

@@ -1,7 +1,6 @@
 using SDL3;
 using System;
 using System.Collections.Generic;
-using System.Runtime.InteropServices;
 
 namespace Staple.Internal;
 
@@ -51,28 +50,18 @@ state.indexBuffer is not SDLGPUIndexBuffer index ||
             buffer = indexBuffer.buffer,
         };
 
-        var scissor = new SDL.SDL_Rect();
-
         if (state.scissor != default)
         {
-            scissor = new()
+            var scissor = new SDL.SDL_Rect()
             {
                 x = state.scissor.left,
                 y = state.scissor.top,
                 w = state.scissor.Width,
                 h = state.scissor.Height,
             };
-        }
-        else
-        {
-            scissor = new()
-            {
-                w = backend.renderSize.X,
-                h = backend.renderSize.Y,
-            };
-        }
 
-        SDL.SDL_SetGPUScissor(renderPass, in scissor);
+            SDL.SDL_SetGPUScissor(renderPass, in scissor);
+        }
 
         SDL.SDL_BindGPUVertexBuffers(renderPass, 0, [vertexBinding], 1);
 

Engine/Staple.Core/Rendering/RenderSystem/Backend/Impls/SDLGPU/SDLGPURendererBackend.cs

@@ -5,7 +5,6 @@
 using System.Numerics;
 using System.Runtime.InteropServices;
 using System.Text;
-using static System.Runtime.InteropServices.JavaScript.JSType;
 
 namespace Staple.Internal;
 
@@ -809,9 +808,19 @@ internal void ResumeRenderPass()
         var depthTarget = new SDL.SDL_GPUDepthStencilTargetInfo()
         {
             clear_depth = 1,
-            load_op = SDL.SDL_GPULoadOp.SDL_GPU_LOADOP_LOAD,
+            load_op = viewData.clearMode switch
+            {
+                CameraClearMode.None => SDL.SDL_GPULoadOp.SDL_GPU_LOADOP_LOAD,
+                _ => SDL.SDL_GPULoadOp.SDL_GPU_LOADOP_CLEAR,
+            },
             store_op = SDL.SDL_GPUStoreOp.SDL_GPU_STOREOP_STORE,
             texture = depthTextureResource.texture,
+            stencil_load_op = viewData.clearMode switch
+            {
+                CameraClearMode.None => SDL.SDL_GPULoadOp.SDL_GPU_LOADOP_LOAD,
+                _ => SDL.SDL_GPULoadOp.SDL_GPU_LOADOP_CLEAR,
+            },
+            stencil_store_op = SDL.SDL_GPUStoreOp.SDL_GPU_STOREOP_STORE,
         };
 
         renderPass = SDL.SDL_BeginGPURenderPass(commandBuffer, [colorTarget], 1, in depthTarget);
@@ -837,6 +846,13 @@ internal void ResumeRenderPass()
     public void BeginRenderPass(RenderTarget target, CameraClearMode clear, Color clearColor, Vector4 viewport,
         in Matrix4x4 view, in Matrix4x4 projection)
     {
+        viewData.renderTarget = target;
+        viewData.clearMode = clear;
+        viewData.clearColor = clearColor;
+        viewData.viewport = viewport;
+        viewData.renderData.view = view;
+        viewData.renderData.projection = projection;
+
         AddCommand(new SDLGPUBeginRenderPassCommand(target, clear, clearColor, viewport, view, projection));
     }
 
@@ -1084,7 +1100,7 @@ instance.program is not SDLGPUShaderProgram shader ||
                     {
                         pitch = (uint)vertexLayout.Stride,
                         slot = 0,
-                        input_rate = SDL.SDL_GPUVertexInputRate.SDL_GPU_VERTEXINPUTRATE_VERTEX
+                        input_rate = SDL.SDL_GPUVertexInputRate.SDL_GPU_VERTEXINPUTRATE_VERTEX,
                     };
 
                     var sourceBlend = state.sourceBlend switch
@@ -1181,7 +1197,7 @@ instance.program is not SDLGPUShaderProgram shader ||
                             {
                                 num_color_targets = 1,
                                 color_target_descriptions = &colorTargetDescription,
-                                has_depth_stencil_target = depthStencilFormat.HasValue,
+                                has_depth_stencil_target = state.enableDepth && depthStencilFormat.HasValue,
                                 depth_stencil_format = sdlDepthFormat,
                             }
                         };

Engine/Staple.Core/Rendering/RenderSystem/RenderSystem+Internal.cs

@@ -496,7 +496,7 @@ private static void PrepareRender(RenderTarget target, CameraClearMode clearMode
         {
             Matrix4x4.Invert(cameraTransform, out var view);
 
-            Backend.BeginRenderPass(target, clearMode, clearColor, viewport, view, projection);
+            Backend.BeginRenderPass(target, clearMode, clearColor, viewport, in view, in projection);
         }
     }
 

Engine/Staple.Editor/ImGuiProxy.cs

@@ -571,8 +571,8 @@ private void Render(ImDrawDataPtr drawData)
                 indexBuffer.Update(indices);
             }
 
-            RenderSystem.Instance.Render(null, CameraClearMode.None, StapleEditor.ClearColor, new(0, 0, 1, 1),
-                Matrix4x4.Identity, ortho,
+            RenderSystem.Instance.Render(null, Scene.current == null ? CameraClearMode.SolidColor : CameraClearMode.None, StapleEditor.ClearColor,
+                new(0, 0, 1, 1), Matrix4x4.Identity, ortho,
                 () =>
                 {
                     currentVertex = 0;

Engine/Staple.Editor/StapleEditor+Render.cs

@@ -204,7 +204,7 @@ public void RenderScene()
             }
         }
 
-        RenderSystem.Instance.Render(null, CameraClearMode.Depth, ClearColor, new(0, 0, 1, 1),
+        RenderSystem.Instance.Render(null, CameraClearMode.SolidColor, ClearColor, new(0, 0, 1, 1),
             cameraTransform.Matrix, projection, () =>
             {
                 wireframeMaterial?.SetVector4("cameraPosition", new Vector4(cameraTransform.Position, 1));

Engine/Staple.Editor/StapleEditor.cs

@@ -850,9 +850,6 @@ private void NormalEditorLoop()
                 return;
             }
 
-            RenderSystem.Instance.Render(null, CameraClearMode.SolidColor, ClearColor, new(0, 0, 1, 1), Matrix4x4.Identity,
-                Matrix4x4.Identity, null);
-
             io.DisplaySize = new Vector2(window.width, window.height);
             io.DisplayFramebufferScale = new Vector2(1, 1);