ci: general improvements #75
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates GitHub Actions workflow configurations with version bumps and cache optimizations. However, there are critical issues with version compatibility and cache key management that need to be addressed.
Key Changes:
- Updates GitHub Actions to newer versions (checkout@v6, upload-artifact@v5, download-artifact@v6)
- Modifies Rust cache configuration by removing architecture-specific keys and adding
cache-targets: false
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/test-template.yml |
Updates action versions and modifies cache configuration, removing architecture-specific cache keys |
.github/workflows/check.yml |
Replaces cache key with cache-targets: false option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - uses: Swatinem/rust-cache@v2 | ||
| with: | ||
| shared-key: ${{ inputs.arch }}-test | ||
| shared-key: test |
There was a problem hiding this comment.
Removing the architecture from the shared cache key could lead to cache conflicts. Previously, each architecture (${{ inputs.arch }}) had its own cache namespace with ${{ inputs.arch }}-test. Now all architectures share the same test key. This could cause tests for different architectures (riscv64, loongarch64, aarch64, x86_64) to overwrite each other's caches or load incompatible cached artifacts, leading to build failures. Consider keeping the architecture-specific key like test-${{ inputs.arch }}.
| - uses: Swatinem/rust-cache@v2 | ||
| with: | ||
| shared-key: ${{ inputs.arch }}-test | ||
| shared-key: test |
There was a problem hiding this comment.
Removing the architecture from the shared cache key could lead to cache conflicts. Previously, each architecture (${{ inputs.arch }}) had its own cache namespace with ${{ inputs.arch }}-test. Now all architectures share the same test key. This could cause builds for different architectures (riscv64, loongarch64, aarch64, x86_64) to overwrite each other's caches or load incompatible cached artifacts, leading to build failures. Consider keeping the architecture-specific key like test-${{ inputs.arch }}.
No description provided.