Handle $ at the end of class names for better Scala support

See https://stackoverflow.com/questions/41570148/why-does-scala-place-a-dollar-sign-at-the-end-of-class-names

Signed-off-by: Dimitry Polivaev <[email protected]>

Author: dpolivaev

archunit/src/main/java/com/tngtech/archunit/core/domain/Formatters.java

@@ -118,11 +118,11 @@ public static String ensureSimpleName(String name) {
         int lastIndexOfDot = name.lastIndexOf('.');
         String partAfterDot = lastIndexOfDot >= 0 ? name.substring(lastIndexOfDot + 1) : name;
 
-        int lastFinalNon$ = partAfterDot.length() - 1;
-        while(lastFinalNon$ > 0 && partAfterDot.charAt(lastFinalNon$) == '$') {
-            lastFinalNon$--;
+        int lastIndexOfNon$ = partAfterDot.length() - 1;
+        while(lastIndexOfNon$ > 0 && partAfterDot.charAt(lastIndexOfNon$) == '$') {
+            lastIndexOfNon$--;
         }
-        int lastIndexOf$ = lastFinalNon$ > 0 ? partAfterDot.lastIndexOf('$', lastFinalNon$ - 1): -1;
+        int lastIndexOf$ = lastIndexOfNon$ > 0 ? partAfterDot.lastIndexOf('$', lastIndexOfNon$ - 1): -1;
         String simpleNameCandidate = lastIndexOf$ >= 0 ? partAfterDot.substring(lastIndexOf$ + 1) : partAfterDot;
 
         for (int i = 0; i < simpleNameCandidate.length(); i++) {