Archunit processing to many classes?

[SimoneGiusso]

I've wrote a rule and activated the debug level. When launching my test I see several logs like these:

DEBUG com.tngtech.archunit.core.importer.JavaClassProcessor -- Processing class '....'

The first lines are my classes but then:

22:51:33.887 [main] DEBUG com.tngtech.archunit.core.importer.JavaClassProcessor -- Processing class 'com/tngtech/archunit/lang/syntax/elements/GivenClassesConjunction'
22:51:33.889 [main] DEBUG com.tngtech.archunit.core.importer.JavaClassProcessor -- Processing class 'com/tngtech/archunit/lang/syntax/elements/ClassesShould'
22:51:33.895 [main] DEBUG com.tngtech.archunit.core.importer.JavaClassProcessor -- Processing class 'java/lang/Double'
22:51:33.898 [main] DEBUG com.tngtech.archunit.core.importer.JavaClassProcessor -- Processing class 'org/mockito/Mock'
22:51:33.899 [main] DEBUG com.tngtech.archunit.core.importer.JavaClassProcessor -- Processing class 'com/tngtech/archunit/lang/syntax/elements/ClassesThat'
22:51:33.901 [main] DEBUG com.tngtech.archunit.core.importer.JavaClassProcessor -- Processing class 'java/lang/Record'
22:51:33.901 [main] DEBUG com.tngtech.archunit.core.importer.JavaClassProcessor -- Processing class 'java/lang/FunctionalInterface'
22:51:33.902 [main] DEBUG com.tngtech.archunit.core.importer.JavaClassProcessor -- Processing class 'org/junit/jupiter/api/extension/ExtendWith'
22:51:33.902 [main] DEBUG com.tngtech.archunit.core.importer.JavaClassProcessor -- Processing class 'com/tngtech/archunit/lang/syntax/ArchRuleDefinition'
...

I'm wondering, is archunit verify the rule on those classes? Ofc the rule should be checked against my classes...

Edit:

Code:

@SuppressWarnings("JUnitTestCaseWithNoTests")
@AnalyzeClasses(packages = APP_PACKAGE)
class ArchitectureTest {

    @ArchTest
    ArchRule only_service_annotation_from_spring_dependency_is_allowed = classes()
        .that().resideInAPackage(APP_PACKAGE)
        .should().onlyDependOnClassesThat(
            resideOutsideOfPackages("org.springframework..").or(type(Service.class))
        ).because("The domain should not depend on technology, but using Spring annotations simplifies dependency injection.");

}

[hankem]

How did you configure your import?

[SimoneGiusso]

I updated the thread. The import is set to default via the annotation. Now as user, I'd default to analyze only my classes. For which reason one should process and apply rules to classes written by others?

[hankem]

If APP_PACKAGE is something like "org.simonegiusso.app", you're primarily resolving your own classes. ✔️

But ArchUnit by default also resolves dependencies found in your classes, see §6.1.1. "Dealing with Missing Classes" and §10.2. "Configuring the Resolution Behavior" of the ArchUnit User Guide, to make sure that dependencies can be properly modeled as well.

If you configure (e.g. via archunit.properties)

resolveMissingDependenciesFromClassPath=false

then you should only get your own classes processed (which can give you wrong results, though).

[SimoneGiusso]

then you should only get your own classes processed (which can give you wrong results, though).

I'm starting to clarify why someone would process third parties library. For example if I don't want my classes to depend on spring but I've some of my classes depend on a third party library class which depends on spring, If I process only my classes the rule will be considered valid even if probably should fail (that's my understanding).

However I'm still critical about the default import setting. Why DoNotIncludeTests is not set by default? Processing the tests file looks like something very rare (I find difficult to think about a use case), therefore should be included explicitly (tests may bring a lot of classes to process - Junit, mockito, etc...)