-
Notifications
You must be signed in to change notification settings - Fork 54
adding shortcuts on the video player buttons controltext #1317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
barisgul15
wants to merge
13
commits into
dev
Choose a base branch
from
1289-showing-shortcuts-on-keyboard-for-relevant-pages
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
bdf64a2
adding shortcuts on the video palyer buttons controltext
barisgul15 ae9ea26
tooltips when mouse is on video player buttons implemented
barisgul15 e1e6251
eslint fix
barisgul15 5918e80
keyboard shortcuts added to hamburger menu on home screen
barisgul15 8bd428e
deleted a console print which I created for debugging
barisgul15 1e9bd81
refactored code changing control texts depending on state
karjo24 16818b9
moved css to appropriate file
karjo24 0b998cf
converted list to @apply
karjo24 bdf90c6
v1 of migrating functions from js file into html file directly
karjo24 50a0c64
uses x-show instead of manually setting display style
karjo24 7cc7659
Merge branch 'dev' into 1289-showing-shortcuts-on-keyboard-for-releva…
karjo24 18cf295
linter fix
karjo24 b67934d
cloaked x-show
karjo24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure we want this on every page and not just on the watch page? The shortcuts are only relevant there, right?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was only a rewrite of the existing, closed PR to better fit our codebase so it can be discussed again. Having said that, I agree. The question is where to incorporate this into the watch page? I'm not too happy about any other place and the menu where it currently is incorporated isn't included in the watch page.