ensure proper deletion of buffers #1726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed unsafe deletion of heap-allocated arrays. The destructor in IfcFileStream previously used delete _buffer; which is incorrect for arrays and can lead to undefined behaviour. It now checks for nullptr. The functions GetVertexData() and GetIndexData() previously returned uint32_t but returned pointer-sized integer values (addresses of vector buffers). These were changed to uintptr_t to safely represent pointer-sized integers on all platforms (including 64-bit/WASM pointers)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed unsafe deletion of heap-allocated arrays. The destructor in IfcFileStream previously used delete _buffer; which is incorrect for arrays and can lead to undefined behaviour. It now checks for nullptr.
The functions
GetVertexData()andGetIndexData()previously returned uint32_t but returned pointer-sized integer values (addresses of vector buffers). These were changed touintptr_tto safely represent pointer-sized integers on all platforms (including 64-bit/WASM pointers)