Actions #17
Open
Actions #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ESLint command used in the GitHub Actions workflow has been updated. Instead of using the generic `npx eslint .`, it now uses `npx expo lint` to better suit our project's needs. The output file and format remain unchanged.
The GitHub Actions linting workflow has been updated to include new permissions for contents and security-events. The installation process now includes global installation of expo-cli and @expo/cli. The ESLint execution step has been split into two separate steps: running Expo Lint, which continues on error, and generating a SARIF report. Lastly, the upload step's name was changed to 'Upload analysis results'.
The ESLint workflow has been refactored for better error handling and efficiency. The 'Run Expo Lint' step was replaced with a direct call to eslint, ensuring that any linting errors will cause the workflow to fail. Additionally, the 'continue-on-error' flag was removed from several steps to ensure that any issues are properly surfaced. The trigger conditions were also simplified by removing specific branch references, allowing the workflow to run on all branches.
- Removed comments from the linting workflow - Adjusted color opacity calculation in DrugDetail component for better accuracy - Replaced index with _index in map function to avoid confusion with global index - Added TypeScript error suppression comment for LineChart due to incomplete TypeScript definitions - Updated source mapping to use Source type instead of any - Implemented optional chaining for drugDetails.links to prevent potential undefined errors - Removed unnecessary import comment in app/index.tsx
The maximum warnings limit for the eslint command in the GitHub Actions workflow has been increased from 0 to 50. This change allows for a more lenient linting process, permitting minor code style deviations while still catching significant issues.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| const AboutRoute = () => { | ||
| import React from 'react'; | ||
| import { View, StyleSheet, ScrollView } from 'react-native'; |
Check warning
Code scanning / ESLint
Disallow unused variables Warning
| <Title style={styles.title}>About TripSit</Title> | ||
| <Surface style={styles.surface}> | ||
| <Text style={styles.text}> | ||
| TripSit began in 2011 as an IRC channel providing drug safety and harm reduction services, allowing people to chat |
Check warning
Code scanning / ESLint
Enforce a maximum line length Warning
| </Surface> | ||
| <Surface style={styles.surface}> | ||
| <Text style={styles.text}> | ||
| TripSit, one of the oldest harm reduction communities, helps by providing factual drug information and a |
Check warning
Code scanning / ESLint
Enforce a maximum line length Warning
| </Surface> | ||
| <Surface style={styles.surface}> | ||
| <Text style={styles.text}> | ||
| Our mission is supporting responsible drug use through education and harm reduction strategies. We aim to reduce |
Check warning
Code scanning / ESLint
Enforce a maximum line length Warning
| </Surface> | ||
| <Surface style={styles.surface}> | ||
| <Text style={styles.text}> | ||
| TripSit remains independent and community-funded, with passionate volunteers providing 24/7 support through our chat |
Check warning
Code scanning / ESLint
Enforce a maximum line length Warning
| </Surface> | ||
| <Surface style={styles.surface}> | ||
| <Text style={styles.text}> | ||
| If you encounter a substance-related crisis situation, please visit chat.tripsit.me for immediate help from |
Check warning
Code scanning / ESLint
Enforce a maximum line length Warning
| </Surface> | ||
| <Surface style={styles.surface}> | ||
| <Text style={styles.text}> | ||
| TripSit aims to provide objective drug information and support, combined with a warm, welcoming community that helps |
Check warning
Code scanning / ESLint
Enforce a maximum line length Warning
| useEffect(() => { | ||
| fetchInteractionResult(); | ||
| }, [selectedDrugs]); | ||
| }, [selectedDrugs, combosData]); |
Check warning
Code scanning / ESLint
verifies the list of dependencies for Hooks like useEffect and similar Warning
The application's version has been incremented from 12.0.3 to 12.0.4 in the configuration file. Correspondingly, the Android version code and runtime version have also been updated to reflect this change.
Significant changes include: - Removed versionToNumber and getRNVersion functions from build.gradle - Updated root, reactNativeDir, and codegenDir paths in build.gradle - Autolinking is now always applied without checking rnVersion - Updated versionCode and versionName in build.gradle - Added ignoreAssetsPattern to androidResources in build.gradle - Removed conditionally applying native_modules.gradle based on rnVersion - Added supportsRtl attribute to application tag in AndroidManifest.xml - Removed DevSettingsActivity from AndroidManifest.xml - Changed import order of SplashScreenManager in MainActivity.kt
.gitignore has been updated to remove specific sync instructions for iOS and Android. New splash screen logos have been added in various resolutions, along with corresponding launcher icons. A new XML file defining the launcher background has also been created.
- Added "expo-localization" to the list of plugins in app.json - Imported useState, useColorScheme, AsyncStorage, format and formatDistanceToNow functions in DrugDetail.tsx - Added new components SegmentedButtons, IconButton, Badge, ProgressBar to the import from 'react-native-paper' - Created new AnimatedCard and AnimatedScrollView components using createAnimatedComponent function - Introduced new state variables selectedTab and lastUpdated for tab management and storing last update time respectively - Implemented useEffect hook to get last updated timestamp from AsyncStorage - Updated headerAnimationStyle with elevation based on scrollY value - Expanded generateChartData function into generateTimelineData for more detailed data generation - Added renderTimeline function to display a timeline view of drug effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.