Skip to content

Commit 0e15a39

Browse files
authored
Merge pull request #2502 from ViewComponent/20251119-ci
Fix bug where error line numbers were incorrect in Rails 8.1
2 parents 833a9cb + 30d1137 commit 0e15a39

19 files changed

+617
-532
lines changed

Appraisals

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ appraise "rails-8.1" do
4545
end
4646

4747
appraise "rails-main" do
48+
ruby "4.0.0.dev"
49+
4850
gem "rack", git: "https://github.com/rack/rack", ref: "8a4475a9f416a72e5b02bd7817e4a8ed684f29b0"
4951
gem "rails", github: "rails/rails", branch: "main"
5052

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ group :development, :test do
1616
gem "appraisal-run", "~> 1.1"
1717
gem "benchmark-ips", "~> 2"
1818
gem "better_html"
19-
gem "bundler", "~> 2"
19+
gem "bundler"
2020
gem "capybara", "~> 3"
2121
gem "cuprite"
2222
gem "dry-initializer", require: true

Gemfile.lock

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ GEM
124124
docile (1.4.1)
125125
drb (2.2.3)
126126
dry-initializer (3.2.0)
127-
erb (5.1.3)
127+
erb (6.0.0)
128128
erb_lint (0.9.0)
129129
activesupport
130130
better_html (>= 2.0.1)
@@ -141,7 +141,7 @@ GEM
141141
websocket-driver (~> 0.7)
142142
globalid (1.3.0)
143143
activesupport (>= 6.1)
144-
haml (6.3.0)
144+
haml (6.4.0)
145145
temple (>= 0.8.2)
146146
thor
147147
tilt
@@ -175,7 +175,7 @@ GEM
175175
matrix (0.4.3)
176176
method_source (1.1.0)
177177
mini_mime (1.1.5)
178-
minitest (5.26.1)
178+
minitest (5.26.2)
179179
net-imap (0.5.12)
180180
date
181181
net-protocol
@@ -185,7 +185,7 @@ GEM
185185
timeout
186186
net-smtp (0.5.1)
187187
net-protocol
188-
nio4r (2.7.4)
188+
nio4r (2.7.5)
189189
nokogiri (1.18.10-aarch64-linux-gnu)
190190
racc (~> 1.4)
191191
nokogiri (1.18.10-aarch64-linux-musl)
@@ -267,18 +267,18 @@ GEM
267267
tsort
268268
redis (5.4.1)
269269
redis-client (>= 0.22.0)
270-
redis-client (0.25.1)
270+
redis-client (0.26.1)
271271
connection_pool
272272
regexp_parser (2.11.3)
273-
reline (0.6.2)
273+
reline (0.6.3)
274274
io-console (~> 0.5)
275275
rexml (3.4.4)
276-
rspec-core (3.13.5)
276+
rspec-core (3.13.6)
277277
rspec-support (~> 3.13.0)
278278
rspec-expectations (3.13.5)
279279
diff-lcs (>= 1.2.0, < 2.0)
280280
rspec-support (~> 3.13.0)
281-
rspec-mocks (3.13.5)
281+
rspec-mocks (3.13.7)
282282
diff-lcs (>= 1.2.0, < 2.0)
283283
rspec-support (~> 3.13.0)
284284
rspec-rails (8.0.2)
@@ -289,19 +289,19 @@ GEM
289289
rspec-expectations (~> 3.13)
290290
rspec-mocks (~> 3.13)
291291
rspec-support (~> 3.13)
292-
rspec-support (3.13.5)
293-
rubocop (1.80.2)
292+
rspec-support (3.13.6)
293+
rubocop (1.81.7)
294294
json (~> 2.3)
295295
language_server-protocol (~> 3.17.0.2)
296296
lint_roller (~> 1.1.0)
297297
parallel (~> 1.10)
298298
parser (>= 3.3.0.2)
299299
rainbow (>= 2.2.2, < 4.0)
300300
regexp_parser (>= 2.9.3, < 3.0)
301-
rubocop-ast (>= 1.46.0, < 2.0)
301+
rubocop-ast (>= 1.47.1, < 2.0)
302302
ruby-progressbar (~> 1.7)
303303
unicode-display_width (>= 2.4.0, < 4.0)
304-
rubocop-ast (1.47.1)
304+
rubocop-ast (1.48.0)
305305
parser (>= 3.3.7.2)
306306
prism (~> 1.4)
307307
rubocop-md (2.0.3)
@@ -342,10 +342,10 @@ GEM
342342
actionpack (>= 6.1)
343343
activesupport (>= 6.1)
344344
sprockets (>= 3.0.0)
345-
standard (1.51.1)
345+
standard (1.52.0)
346346
language_server-protocol (~> 3.17.0.2)
347347
lint_roller (~> 1.0)
348-
rubocop (~> 1.80.2)
348+
rubocop (~> 1.81.7)
349349
standard-custom (~> 1.0.0)
350350
standard-performance (~> 1.8)
351351
standard-custom (1.0.2)
@@ -354,7 +354,7 @@ GEM
354354
standard-performance (1.8.0)
355355
lint_roller (~> 1.1)
356356
rubocop-performance (~> 1.25.0)
357-
stringio (3.1.7)
357+
stringio (3.1.8)
358358
tailwindcss-rails (4.4.0)
359359
railties (>= 7.0.0)
360360
tailwindcss-ruby (~> 4.0)
@@ -365,12 +365,12 @@ GEM
365365
tailwindcss-ruby (4.1.16-x86_64-darwin)
366366
tailwindcss-ruby (4.1.16-x86_64-linux-gnu)
367367
tailwindcss-ruby (4.1.16-x86_64-linux-musl)
368-
temple (0.10.3)
368+
temple (0.10.4)
369369
terminal-table (4.0.0)
370370
unicode-display_width (>= 1.1.1, < 4)
371371
thor (1.4.0)
372372
tilt (2.6.1)
373-
timeout (0.4.3)
373+
timeout (0.4.4)
374374
tsort (0.2.0)
375375
turbo-rails (2.0.20)
376376
actionpack (>= 7.1.0)
@@ -412,7 +412,7 @@ DEPENDENCIES
412412
appraisal-run (~> 1.1)
413413
benchmark-ips (~> 2)
414414
better_html
415-
bundler (~> 2)
415+
bundler
416416
capybara (~> 3)
417417
cuprite
418418
dry-initializer
@@ -444,7 +444,7 @@ DEPENDENCIES
444444
yard-activesupport-concern (< 1)
445445

446446
RUBY VERSION
447-
ruby 3.4.2p28
447+
ruby 3.4.3p32
448448

449449
BUNDLED WITH
450450
2.6.2

docs/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ nav_order: 6
1010

1111
## main
1212

13+
* Fix bug where error line numbers were incorrect in Rails 8.1.
14+
15+
*Joel Hawksley*
16+
1317
* Remove `< 8.2` upper bound for `activesupport` and `actionview` dependencies.
1418

1519
*Hans Lemuet*

gemfiles/rails_7.1.gemfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ gem "rails", "~> 7.1.0"
99
group :development, :test do
1010
gem "allocation_stats"
1111
gem "appraisal", "~> 2"
12-
gem "appraisal-run", "~> 1.0"
12+
gem "appraisal-run", "~> 1.1"
1313
gem "benchmark-ips", "~> 2"
1414
gem "better_html"
1515
gem "bundler", "~> 2"
@@ -23,7 +23,7 @@ group :development, :test do
2323
gem "method_source", "~> 1"
2424
gem "minitest", "~> 5"
2525
gem "propshaft", "~> 1"
26-
gem "puma", "~> 6"
26+
gem "puma", ">= 6"
2727
gem "rake", "~> 13"
2828
gem "rails-dom-testing", "~> 2.3.0"
2929
gem "redis"

0 commit comments

Comments
 (0)