Add support for configuring a HTTP proxy for EWS requests #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, you have to subclass Viewpoint::EWS::Connection to be able to gain access to the HTTP client so that a proxy URL and proxy authentication can be configured. This commit adds options that can be passed to EWSClient.new to do this directly. It also supports setting the proxy credentials later using the `#set_proxy_auth` call on the connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, you have to subclass
Viewpoint::EWS::Connectionto be able to gain access to the HTTP client so that a proxy URL and proxy authentication can be configured. This commit adds options that can be passed toEWSClient.newto do this directly.It also supports setting the proxy credentials later using the
#set_proxy_authcall on the connection.